Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: base/files/important_file_writer_unittest.cc

Issue 1127963002: Implement lossy pref behavior for JsonPrefStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-fix-flags
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/important_file_writer.h" 5 #include "base/files/important_file_writer.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 protected: 92 protected:
93 SuccessfulWriteObserver successful_write_observer_; 93 SuccessfulWriteObserver successful_write_observer_;
94 FilePath file_; 94 FilePath file_;
95 MessageLoop loop_; 95 MessageLoop loop_;
96 96
97 private: 97 private:
98 ScopedTempDir temp_dir_; 98 ScopedTempDir temp_dir_;
99 }; 99 };
100 100
101 TEST_F(ImportantFileWriterTest, Basic) { 101 TEST_F(ImportantFileWriterTest, Basic) {
102 ImportantFileWriter writer(file_, ThreadTaskRunnerHandle::Get()); 102 ImportantFileWriterImpl writer(file_, ThreadTaskRunnerHandle::Get());
103 EXPECT_FALSE(PathExists(writer.path())); 103 EXPECT_FALSE(PathExists(writer.path()));
104 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState()); 104 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());
105 writer.WriteNow(make_scoped_ptr(new std::string("foo"))); 105 writer.WriteNow(make_scoped_ptr(new std::string("foo")));
106 RunLoop().RunUntilIdle(); 106 RunLoop().RunUntilIdle();
107 107
108 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState()); 108 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());
109 ASSERT_TRUE(PathExists(writer.path())); 109 ASSERT_TRUE(PathExists(writer.path()));
110 EXPECT_EQ("foo", GetFileContent(writer.path())); 110 EXPECT_EQ("foo", GetFileContent(writer.path()));
111 } 111 }
112 112
113 TEST_F(ImportantFileWriterTest, BasicWithSuccessfulWriteObserver) { 113 TEST_F(ImportantFileWriterTest, BasicWithSuccessfulWriteObserver) {
114 ImportantFileWriter writer(file_, ThreadTaskRunnerHandle::Get()); 114 ImportantFileWriterImpl writer(file_, ThreadTaskRunnerHandle::Get());
115 EXPECT_FALSE(PathExists(writer.path())); 115 EXPECT_FALSE(PathExists(writer.path()));
116 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState()); 116 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());
117 successful_write_observer_.ObserveNextSuccessfulWrite(&writer); 117 successful_write_observer_.ObserveNextSuccessfulWrite(&writer);
118 writer.WriteNow(make_scoped_ptr(new std::string("foo"))); 118 writer.WriteNow(make_scoped_ptr(new std::string("foo")));
119 RunLoop().RunUntilIdle(); 119 RunLoop().RunUntilIdle();
120 120
121 // Confirm that the observer is invoked. 121 // Confirm that the observer is invoked.
122 EXPECT_TRUE(successful_write_observer_.GetAndResetObservationState()); 122 EXPECT_TRUE(successful_write_observer_.GetAndResetObservationState());
123 ASSERT_TRUE(PathExists(writer.path())); 123 ASSERT_TRUE(PathExists(writer.path()));
124 EXPECT_EQ("foo", GetFileContent(writer.path())); 124 EXPECT_EQ("foo", GetFileContent(writer.path()));
(...skipping 13 matching lines...) Expand all
138 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState()); 138 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());
139 writer.WriteNow(make_scoped_ptr(new std::string("baz"))); 139 writer.WriteNow(make_scoped_ptr(new std::string("baz")));
140 RunLoop().RunUntilIdle(); 140 RunLoop().RunUntilIdle();
141 141
142 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState()); 142 EXPECT_FALSE(successful_write_observer_.GetAndResetObservationState());
143 ASSERT_TRUE(PathExists(writer.path())); 143 ASSERT_TRUE(PathExists(writer.path()));
144 EXPECT_EQ("baz", GetFileContent(writer.path())); 144 EXPECT_EQ("baz", GetFileContent(writer.path()));
145 } 145 }
146 146
147 TEST_F(ImportantFileWriterTest, ScheduleWrite) { 147 TEST_F(ImportantFileWriterTest, ScheduleWrite) {
148 ImportantFileWriter writer(file_, ThreadTaskRunnerHandle::Get()); 148 ImportantFileWriterImpl writer(file_, ThreadTaskRunnerHandle::Get());
149 writer.set_commit_interval(TimeDelta::FromMilliseconds(25)); 149 writer.set_commit_interval(TimeDelta::FromMilliseconds(25));
150 EXPECT_FALSE(writer.HasPendingWrite()); 150 EXPECT_FALSE(writer.HasPendingWrite());
151 DataSerializer serializer("foo"); 151 DataSerializer serializer("foo");
152 writer.ScheduleWrite(&serializer); 152 writer.ScheduleWrite(&serializer);
153 EXPECT_TRUE(writer.HasPendingWrite()); 153 EXPECT_TRUE(writer.HasPendingWrite());
154 ThreadTaskRunnerHandle::Get()->PostDelayedTask( 154 ThreadTaskRunnerHandle::Get()->PostDelayedTask(
155 FROM_HERE, MessageLoop::QuitWhenIdleClosure(), 155 FROM_HERE, MessageLoop::QuitWhenIdleClosure(),
156 TimeDelta::FromMilliseconds(100)); 156 TimeDelta::FromMilliseconds(100));
157 MessageLoop::current()->Run(); 157 MessageLoop::current()->Run();
158 EXPECT_FALSE(writer.HasPendingWrite()); 158 EXPECT_FALSE(writer.HasPendingWrite());
159 ASSERT_TRUE(PathExists(writer.path())); 159 ASSERT_TRUE(PathExists(writer.path()));
160 EXPECT_EQ("foo", GetFileContent(writer.path())); 160 EXPECT_EQ("foo", GetFileContent(writer.path()));
161 } 161 }
162 162
163 TEST_F(ImportantFileWriterTest, DoScheduledWrite) { 163 TEST_F(ImportantFileWriterTest, DoScheduledWrite) {
164 ImportantFileWriter writer(file_, ThreadTaskRunnerHandle::Get()); 164 ImportantFileWriterImpl writer(file_, ThreadTaskRunnerHandle::Get());
165 EXPECT_FALSE(writer.HasPendingWrite()); 165 EXPECT_FALSE(writer.HasPendingWrite());
166 DataSerializer serializer("foo"); 166 DataSerializer serializer("foo");
167 writer.ScheduleWrite(&serializer); 167 writer.ScheduleWrite(&serializer);
168 EXPECT_TRUE(writer.HasPendingWrite()); 168 EXPECT_TRUE(writer.HasPendingWrite());
169 writer.DoScheduledWrite(); 169 writer.DoScheduledWrite();
170 ThreadTaskRunnerHandle::Get()->PostDelayedTask( 170 ThreadTaskRunnerHandle::Get()->PostDelayedTask(
171 FROM_HERE, MessageLoop::QuitWhenIdleClosure(), 171 FROM_HERE, MessageLoop::QuitWhenIdleClosure(),
172 TimeDelta::FromMilliseconds(100)); 172 TimeDelta::FromMilliseconds(100));
173 MessageLoop::current()->Run(); 173 MessageLoop::current()->Run();
174 EXPECT_FALSE(writer.HasPendingWrite()); 174 EXPECT_FALSE(writer.HasPendingWrite());
175 ASSERT_TRUE(PathExists(writer.path())); 175 ASSERT_TRUE(PathExists(writer.path()));
176 EXPECT_EQ("foo", GetFileContent(writer.path())); 176 EXPECT_EQ("foo", GetFileContent(writer.path()));
177 } 177 }
178 178
179 TEST_F(ImportantFileWriterTest, BatchingWrites) { 179 TEST_F(ImportantFileWriterTest, BatchingWrites) {
180 ImportantFileWriter writer(file_, ThreadTaskRunnerHandle::Get()); 180 ImportantFileWriterImpl writer(file_, ThreadTaskRunnerHandle::Get());
181 writer.set_commit_interval(TimeDelta::FromMilliseconds(25)); 181 writer.set_commit_interval(TimeDelta::FromMilliseconds(25));
182 DataSerializer foo("foo"), bar("bar"), baz("baz"); 182 DataSerializer foo("foo"), bar("bar"), baz("baz");
183 writer.ScheduleWrite(&foo); 183 writer.ScheduleWrite(&foo);
184 writer.ScheduleWrite(&bar); 184 writer.ScheduleWrite(&bar);
185 writer.ScheduleWrite(&baz); 185 writer.ScheduleWrite(&baz);
186 ThreadTaskRunnerHandle::Get()->PostDelayedTask( 186 ThreadTaskRunnerHandle::Get()->PostDelayedTask(
187 FROM_HERE, MessageLoop::QuitWhenIdleClosure(), 187 FROM_HERE, MessageLoop::QuitWhenIdleClosure(),
188 TimeDelta::FromMilliseconds(100)); 188 TimeDelta::FromMilliseconds(100));
189 MessageLoop::current()->Run(); 189 MessageLoop::current()->Run();
190 ASSERT_TRUE(PathExists(writer.path())); 190 ASSERT_TRUE(PathExists(writer.path()));
191 EXPECT_EQ("baz", GetFileContent(writer.path())); 191 EXPECT_EQ("baz", GetFileContent(writer.path()));
192 } 192 }
193 193
194 } // namespace base 194 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698