Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1127913002: Change kMaxDescriptorsPerMessage back to 7 (Closed)

Created:
5 years, 7 months ago by Yusuke Sato
Modified:
5 years, 7 months ago
Reviewers:
Mark Seaborn, bbudge, agl
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, Tom Sepez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change kMaxDescriptorsPerMessage back to 7 This is a partial revert of crrev.com/320831 which increased Chrome's memory usage by 106KB per IPC::Channel. BUG=484154 TEST=git cl try Committed: https://crrev.com/c986c543f807c5bca25872c929ca29a6ff982506 Cr-Commit-Position: refs/heads/master@{#328587}

Patch Set 1 #

Patch Set 2 : review #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M components/nacl/browser/nacl_host_message_filter.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ipc/ipc_message_attachment_set.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/tests/extensions/packaged_app/test_packaged_app.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Yusuke Sato
Adam, Mark, could you take a look?
5 years, 7 months ago (2015-05-06 01:35:26 UTC) #2
Mark Seaborn
LGTM https://codereview.chromium.org/1127913002/diff/20001/components/nacl/browser/nacl_host_message_filter.cc File components/nacl/browser/nacl_host_message_filter.cc (right): https://codereview.chromium.org/1127913002/diff/20001/components/nacl/browser/nacl_host_message_filter.cc#newcode31 components/nacl/browser/nacl_host_message_filter.cc:31: // TODO(nativeclient:3802): Remove |kMaxPreOpenResourceFiles|. Instead, send Nit: the ...
5 years, 7 months ago (2015-05-06 17:22:22 UTC) #3
Yusuke Sato
https://codereview.chromium.org/1127913002/diff/20001/components/nacl/browser/nacl_host_message_filter.cc File components/nacl/browser/nacl_host_message_filter.cc (right): https://codereview.chromium.org/1127913002/diff/20001/components/nacl/browser/nacl_host_message_filter.cc#newcode31 components/nacl/browser/nacl_host_message_filter.cc:31: // TODO(nativeclient:3802): Remove |kMaxPreOpenResourceFiles|. Instead, send On 2015/05/06 17:22:21, ...
5 years, 7 months ago (2015-05-06 17:50:16 UTC) #4
Yusuke Sato
+Bill Please take a look at ppapi/.
5 years, 7 months ago (2015-05-06 17:50:57 UTC) #6
bbudge
ppapi LGTM
5 years, 7 months ago (2015-05-06 17:59:14 UTC) #7
agl
ipc/ LGTM.
5 years, 7 months ago (2015-05-06 19:17:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127913002/40001
5 years, 7 months ago (2015-05-06 19:40:40 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-06 19:45:55 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 19:46:53 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c986c543f807c5bca25872c929ca29a6ff982506
Cr-Commit-Position: refs/heads/master@{#328587}

Powered by Google App Engine
This is Rietveld 408576698