Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1127893002: Add DataReductionProxyExperimentsStats and UMA for measuring potentially non-compressed bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update histogram comment. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ec6f782a9686cb13e50769ad4e1371e4ef6fe9d3..b92ce535305b6c3c8a8f9cafc26b88b74de4596d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -4233,6 +4233,40 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="DataReductionProxy.ConfigFetchLostBytesCL">
+ <owner>jeremyim@chromium.org</owner>
+ <owner>bengr@chromium.org</owner>
+ <summary>
+ Size of the response body. This is the actual number of bytes received,
+ which usually agrees with but is not necessarily the same as the size
+ specified by the Content-Length header. Only recorded if the request is sent
+ while a simulated Data Reduction Proxy configuration fetch is taking place.
+ </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.ConfigFetchLostBytesDiff">
+ <owner>jeremyim@chromium.org</owner>
+ <owner>bengr@chromium.org</owner>
+ <summary>
+ The difference between the size specified in the X-Original-Content-Length
+ header and the size of the response body. Only recorded if the request is
+ sent while a simulated Data Reduction Proxy configuration fetch is taking
+ place. Only positive values are logged, so if X-Original-Content-Length is
sclittle 2015/05/14 18:33:47 nit: remove extra space between "if" and "X-Origin
+ not specified or exceeds the content length, it is not logged.
Alexei Svitkine (slow) 2015/05/14 18:34:50 With your current code, it also won't be logged if
+ </summary>
+</histogram>
+
+<histogram name="DataReductionProxy.ConfigFetchLostBytesOCL">
+ <owner>jeremyim@chromium.org</owner>
+ <owner>bengr@chromium.org</owner>
+ <summary>
+ Size specified in the X-Original-Content-Length header. If this header is
+ not present in the response, the size of the response body is used. Only
+ recorded if the request is sent while a simulated Data Reduction Proxy
+ configuration fetch is taking place.
+ </summary>
+</histogram>
+
<histogram
name="DataReductionProxy.ConfigService.FetchFailedAttemptsBeforeSuccess">
<owner>jeremyim@chromium.org</owner>
@@ -66212,6 +66246,22 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="DataReductionProxy.BypassedBytes"/>
</histogram_suffixes>
+<histogram_suffixes name="DataReductionProxyConfigFetchLostBytes" separator="_">
+ <suffix name="0" label="Bucket 0 for gathering multiple data points."/>
+ <suffix name="1" label="Bucket 1 for gathering multiple data points."/>
+ <suffix name="2" label="Bucket 2 for gathering multiple data points."/>
+ <suffix name="3" label="Bucket 3 for gathering multiple data points."/>
+ <suffix name="4" label="Bucket 4 for gathering multiple data points."/>
+ <suffix name="5" label="Bucket 5 for gathering multiple data points."/>
+ <suffix name="6" label="Bucket 6 for gathering multiple data points."/>
+ <suffix name="7" label="Bucket 7 for gathering multiple data points."/>
+ <suffix name="8" label="Bucket 8 for gathering multiple data points."/>
+ <suffix name="9" label="Bucket 9 for gathering multiple data points."/>
+ <affected-histogram name="DataReductionProxy.ConfigFetchLostBytesCL"/>
+ <affected-histogram name="DataReductionProxy.ConfigFetchLostBytesDiff"/>
+ <affected-histogram name="DataReductionProxy.ConfigFetchLostBytesOCL"/>
+</histogram_suffixes>
+
<histogram_suffixes name="DataReductionProxyMissingViaHeaderBytes"
separator=".">
<suffix name="4xx" label="Response with 4xx response code"/>
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698