Issue 112783004: ensure that we call onUnlock only when we onLock succeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112783004: ensure that we call onUnlock only when we onLock succeeded (Closed)

Created:
7 years ago by reed1

Modified:
7 years ago

Reviewers:
hal.canary, scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ensure that we call onUnlock only when we onLock succeeded BUG= R=halcanary@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12642

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -26 lines)			Patch
M	include/core/SkPixelRef.h	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	2 chunks	+12 lines, -3 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	src/images/SkImageRef_ashmem.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

7 years ago (2013-12-12 18:06:28 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/93673005/ by robertphillips@google.com.

The reason for reverting is: Failing assert on Android.

Expand Messages | Collapse Messages