Chromium Code Reviews

Issue 1127823002: Add libteken (from FreeBSD) to third_party. (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add libteken (from FreeBSD) to third_party. I'll need it for a terminal emulator. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/71ab8c28d275834d5ceec05a76a5036173e328c0

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed unused stuff #

Unified diffs Side-by-side diffs Stats (+3239 lines, -0 lines)
A third_party/libteken/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments
A third_party/libteken/COPYRIGHT View 1 chunk +126 lines, -0 lines 0 comments
A third_party/libteken/README.chromium View 1 chunk +22 lines, -0 lines 0 comments
A third_party/libteken/teken/gensequences View 1 chunk +157 lines, -0 lines 0 comments
A third_party/libteken/teken/sequences View 1 chunk +113 lines, -0 lines 0 comments
A third_party/libteken/teken/teken.h View 1 chunk +223 lines, -0 lines 0 comments
A third_party/libteken/teken/teken.c View 1 chunk +558 lines, -0 lines 0 comments
A third_party/libteken/teken/teken_scs.h View 1 chunk +80 lines, -0 lines 0 comments
A third_party/libteken/teken/teken_state.h View 1 chunk +383 lines, -0 lines 0 comments
A third_party/libteken/teken/teken_subr.h View 1 chunk +1306 lines, -0 lines 0 comments
A third_party/libteken/teken/teken_subr_compat.h View 1 chunk +126 lines, -0 lines 0 comments
A third_party/libteken/teken/teken_wcwidth.h View 1 chunk +120 lines, -0 lines 0 comments

Messages

Total messages: 5 (0 generated)
viettrungluu
5 years, 7 months ago (2015-05-05 17:18:00 UTC) #1
jamesr
Could we cut this down to just the files we plan to link in? https://codereview.chromium.org/1127823002/diff/1/third_party/libteken/teken/demo/Makefile ...
5 years, 7 months ago (2015-05-05 17:22:28 UTC) #2
viettrungluu
PTAL. On 2015/05/05 17:22:28, jamesr wrote: > Could we cut this down to just the ...
5 years, 7 months ago (2015-05-05 17:35:56 UTC) #3
jamesr
lgtm
5 years, 7 months ago (2015-05-05 19:44:18 UTC) #4
viettrungluu
5 years, 7 months ago (2015-05-05 20:08:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
71ab8c28d275834d5ceec05a76a5036173e328c0 (presubmit successful).

Powered by Google App Engine