Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127773003: This CL clean up patch in SVGElements. (Closed)

Created:
5 years, 7 months ago by hyunjunekim2
Modified:
5 years, 7 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor 0 -> nullptr in SVGElements. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M Source/core/svg/SVGDocumentExtensions.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGElementRareData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLengthContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGURIReference.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hyunjunekim2
Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). Could you check this patch? This cl just clean up. ...
5 years, 7 months ago (2015-05-05 03:26:10 UTC) #2
pdr.
LGTM Before landing please update the change description to be something like "Refactor 0 -> ...
5 years, 7 months ago (2015-05-05 04:47:04 UTC) #3
hyunjunekim2
pdr, I modified description.
5 years, 7 months ago (2015-05-05 05:44:57 UTC) #4
pdr.
lgtm Thanks Go-go gadget
5 years, 7 months ago (2015-05-05 05:57:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127773003/1
5 years, 7 months ago (2015-05-05 05:58:07 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 07:48:03 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194916

Powered by Google App Engine
This is Rietveld 408576698