Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: Source/modules/vibration/NavigatorVibration.cpp

Issue 1127713005: Change kVibrationDurationMax to be file-local to NavigatorVibration. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | public/platform/WebVibration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/vibration/NavigatorVibration.cpp
diff --git a/Source/modules/vibration/NavigatorVibration.cpp b/Source/modules/vibration/NavigatorVibration.cpp
index 5cfab2e00b986a280c51b99f0dde61f39167f14c..c14343c39479bb1b55dcd839b6f42a03ec30aa4d 100644
--- a/Source/modules/vibration/NavigatorVibration.cpp
+++ b/Source/modules/vibration/NavigatorVibration.cpp
@@ -25,11 +25,13 @@
#include "core/frame/Navigator.h"
#include "core/page/PageVisibilityState.h"
#include "public/platform/Platform.h"
-#include "public/platform/WebVibration.h"
// Maximum number of entries in a vibration pattern.
const unsigned kVibrationPatternLengthMax = 99;
+// Maximum duration of a vibration is 10 seconds.
+const unsigned kVibrationDurationMax = 10000;
jochen (gone - plz use gerrit) 2015/05/05 15:18:01 please add a unit of time to the variable name (I
Peter Beverloo 2015/05/05 15:46:55 Done.
+
blink::NavigatorVibration::VibrationPattern sanitizeVibrationPatternInternal(const blink::NavigatorVibration::VibrationPattern& pattern)
{
blink::NavigatorVibration::VibrationPattern sanitized = pattern;
@@ -43,8 +45,8 @@ blink::NavigatorVibration::VibrationPattern sanitizeVibrationPatternInternal(con
// If any pattern entry is too long then truncate it.
for (size_t i = 0; i < length; ++i) {
- if (sanitized[i] > blink::kVibrationDurationMax)
- sanitized[i] = blink::kVibrationDurationMax;
+ if (sanitized[i] > kVibrationDurationMax)
+ sanitized[i] = kVibrationDurationMax;
}
// If the last item in the pattern is a pause then discard it.
« no previous file with comments | « no previous file | public/platform/WebVibration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698