Change kVibrationDurationMax to be file-local to NavigatorVibration.

Change kVibrationDurationMax to be file-local to NavigatorVibration.

There's only one use of this constant, which is in a file in Blink, so
there's no need to expose it as part of the Blink API.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194933

[Peter Beverloo, 2015-05-05 13:01:41]

peter@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-05-05 13:01:41]

+mvanouwerkerk for vibration

[Michael van Ouwerkerk, 2015-05-05 13:30:58]

lgtm

The original reviewer insisted on doing it like this, but I never liked it.

[Peter Beverloo, 2015-05-05 13:47:26]

Do you have a reference to that comment?

[Michael van Ouwerkerk, 2015-05-05 14:04:50]

On 2015/05/05 13:47:26, Peter Beverloo wrote:
> Do you have a reference to that comment?

https://codereview.chromium.org/16781002/diff/86001/content/browser/vibration...

Looks like its content/ usage was removed at some point though.

[Peter Beverloo, 2015-05-05 14:08:08]

peter@chromium.org changed reviewers:
+ jochen@chromium.org

[Peter Beverloo, 2015-05-05 14:08:08]

Cool, thanks!

+jochen for public/ stamp.

[jochen (gone - plz use gerrit), 2015-05-05 15:18:02]

lgtm with nit

https://codereview.chromium.org/1127713005/diff/1/Source/modules/vibration/Na...
File Source/modules/vibration/NavigatorVibration.cpp (right):

https://codereview.chromium.org/1127713005/diff/1/Source/modules/vibration/Na...
Source/modules/vibration/NavigatorVibration.cpp:33: const unsigned
kVibrationDurationMax = 10000;
please add a unit of time to the variable name (I guess Ms?)

[Peter Beverloo, 2015-05-05 15:46:55]

https://codereview.chromium.org/1127713005/diff/1/Source/modules/vibration/Na...
File Source/modules/vibration/NavigatorVibration.cpp (right):

https://codereview.chromium.org/1127713005/diff/1/Source/modules/vibration/Na...
Source/modules/vibration/NavigatorVibration.cpp:33: const unsigned
kVibrationDurationMax = 10000;
On 2015/05/05 15:18:01, jochen wrote:
> please add a unit of time to the variable name (I guess Ms?)

Done.

[Peter Beverloo, 2015-05-05 15:46:58]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-05-05 15:46:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1127713005/#ps20001
(title: "commenst")

[commit-bot: I haz the power, 2015-05-05 15:48:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1127713005/20001

[commit-bot: I haz the power, 2015-05-05 18:25:51]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194933