Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1127713004: Revert of Add granular base::File tracing. (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@do-initialize
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add granular base::File tracing. (patchset #10 id:490001 of https://codereview.chromium.org/1072133006/) Reason for revert: See if this broke sizes by increasing setup.exe by 0.43%. Original issue's description: > Add granular base::File tracing. > > R=thestig@chromium.org,nduca@chromium.org > BUG=480665 > > Committed: https://crrev.com/a6e05c977096a03774e5406d63ad80c0166f9adc > Cr-Commit-Position: refs/heads/master@{#328153} TBR=thestig@chromium.org,nduca@chromium.org,oysteine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480665 Committed: https://crrev.com/0f045e96533304388b88da9c4af42039790d8942 Cr-Commit-Position: refs/heads/master@{#328241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -250 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M base/files/file.h View 8 chunks +9 lines, -22 lines 0 comments Download
M base/files/file.cc View 6 chunks +5 lines, -19 lines 0 comments Download
M base/files/file_posix.cc View 18 chunks +5 lines, -32 lines 0 comments Download
D base/files/file_tracing.h View 1 chunk +0 lines, -68 lines 0 comments Download
D base/files/file_tracing.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M base/files/file_win.cc View 16 chunks +7 lines, -38 lines 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +4 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Add granular base::File tracing.
5 years, 7 months ago (2015-05-05 00:49:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127713004/1
5 years, 7 months ago (2015-05-05 00:51:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 00:53:15 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 00:54:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f045e96533304388b88da9c4af42039790d8942
Cr-Commit-Position: refs/heads/master@{#328241}

Powered by Google App Engine
This is Rietveld 408576698