Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127693006: Reland #2 "Wrap v8natives.js into a function." (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland #2 "Wrap v8natives.js into a function." TBR=machenbach@chromium.org Committed: https://crrev.com/b0eb920fe27517722f4b5888a37713f95168fd43 Cr-Commit-Position: refs/heads/master@{#28217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -372 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 9 chunks +10 lines, -10 lines 0 comments Download
M src/array-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/collection.js View 6 chunks +8 lines, -8 lines 0 comments Download
M src/collection-iterator.js View 2 chunks +6 lines, -6 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/generator.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 5 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 3 chunks +9 lines, -4 lines 0 comments Download
M src/i18n.js View 28 chunks +60 lines, -61 lines 0 comments Download
M src/json.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 12 chunks +23 lines, -15 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/object-observe.js View 6 chunks +9 lines, -9 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/symbol.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 7 chunks +37 lines, -31 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 14 chunks +204 lines, -175 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/jsmin.py View 7 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127693006/1
5 years, 7 months ago (2015-05-05 08:47:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 09:16:03 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 09:16:15 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b0eb920fe27517722f4b5888a37713f95168fd43
Cr-Commit-Position: refs/heads/master@{#28217}

Powered by Google App Engine
This is Rietveld 408576698