Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1127693002: Remove canTweakAlphaForCoverage from XP's since batch reads flag. (Closed)

Created:
5 years, 7 months ago by egdaniel
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove canTweakAlphaForCoverage from XP's since batch reads flag. BUG=skia: Committed: https://skia.googlesource.com/skia/+/99bc9fdfb555f1cf8e426329633e735e3020b829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -41 lines) Patch
M include/gpu/GrXferProcessor.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/gpu/effects/GrCoverageSetOpXP.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
egdaniel
PTAL. Simply removing old, unused code
5 years, 7 months ago (2015-05-04 19:37:09 UTC) #2
joshualitt
On 2015/05/04 19:37:09, egdaniel wrote: > PTAL. Simply removing old, unused code lgtm
5 years, 7 months ago (2015-05-04 19:40:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127693002/1
5 years, 7 months ago (2015-05-04 19:45:32 UTC) #5
commit-bot: I haz the power
Presubmit check for 1127693002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-04 19:45:39 UTC) #7
reed1
api lgtm
5 years, 7 months ago (2015-05-04 19:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127693002/1
5 years, 7 months ago (2015-05-04 19:55:07 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 19:58:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/99bc9fdfb555f1cf8e426329633e735e3020b829

Powered by Google App Engine
This is Rietveld 408576698