Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1127653003: Do not swallow compilation errors when setting breakpoint (Closed)

Created:
5 years, 7 months ago by hausner
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Do not swallow compilation errors when setting breakpoint Fixes 23352 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 3 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 7 months ago (2015-05-04 20:58:40 UTC) #2
Cutch
lgtm
5 years, 7 months ago (2015-05-04 20:59:30 UTC) #3
hausner
5 years, 7 months ago (2015-05-04 21:03:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698