Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1127623005: Gather metrics classifying the cause of the TLS fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-required
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« net/ssl/ssl_failure_state.h ('K') | « net/ssl/ssl_failure_state.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index ae71f4a2659182867760a8de49a11616700fcca0..4e844eda2533c093ba9c84159faf58e71a850ea0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -22031,6 +22031,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>Time to complete a certificate verification (error case).</summary>
</histogram>
+<histogram name="Net.SSLFallbackErrorCode" enum="NetErrorCodes">
+ <owner>davidben@chromium.org</owner>
+ <summary>
+ For each successful HTTPS request which used the TLS version fallback, the
+ error code of the last failed attempt.
+ </summary>
+</histogram>
+
+<histogram name="Net.SSLFallbackFailureState" enum="SSLFailureState">
+ <owner>davidben@chromium.org</owner>
+ <summary>
+ For each successful HTTPS request which used the TLS version fallback, the
+ type of handshake failure of the last failed attempt.
+ </summary>
+</histogram>
+
<histogram name="Net.SSLHostInfoDNSLookup" units="milliseconds">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<summary>Time to complete a DNS lookup for a DNS CAA record.</summary>
@@ -63908,6 +63924,16 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="9" label="UNKNOWN"/>
</enum>
+<enum name="SSLFailureState" type="int">
+ <int value="0" label="No failure"/>
+ <int value="1" label="Unknown failure"/>
+ <int value="2" label="Failed to process ClientHello"/>
+ <int value="3" label="Buggy AES-GCM"/>
+ <int value="4" label="Failed with client authentication"/>
+ <int value="5" label="Session version mismatch"/>
+ <int value="6" label="Failed with Next Proto Negotiation"/>
+</enum>
+
<enum name="SSLGoodCertSeenEvent" type="int">
<int value="0" label="NO_PREVIOUS_EXCEPTION"/>
<int value="1" label="HAD_PREVIOUS_EXCEPTION"/>
« net/ssl/ssl_failure_state.h ('K') | « net/ssl/ssl_failure_state.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698