Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: net/socket/ssl_client_socket_openssl.cc

Issue 1127623005: Gather metrics classifying the cause of the TLS fallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-required
Patch Set: missing header Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.h ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // OpenSSL binding for SSLClientSocket. The class layout and general principle 5 // OpenSSL binding for SSLClientSocket. The class layout and general principle
6 // of operation is derived from SSLClientSocketNSS. 6 // of operation is derived from SSLClientSocketNSS.
7 7
8 #include "net/socket/ssl_client_socket_openssl.h" 8 #include "net/socket/ssl_client_socket_openssl.h"
9 9
10 #include <errno.h> 10 #include <errno.h>
(...skipping 20 matching lines...) Expand all
31 #include "net/cert/cert_verifier.h" 31 #include "net/cert/cert_verifier.h"
32 #include "net/cert/ct_ev_whitelist.h" 32 #include "net/cert/ct_ev_whitelist.h"
33 #include "net/cert/ct_verifier.h" 33 #include "net/cert/ct_verifier.h"
34 #include "net/cert/x509_certificate_net_log_param.h" 34 #include "net/cert/x509_certificate_net_log_param.h"
35 #include "net/cert/x509_util_openssl.h" 35 #include "net/cert/x509_util_openssl.h"
36 #include "net/http/transport_security_state.h" 36 #include "net/http/transport_security_state.h"
37 #include "net/ssl/scoped_openssl_types.h" 37 #include "net/ssl/scoped_openssl_types.h"
38 #include "net/ssl/ssl_cert_request_info.h" 38 #include "net/ssl/ssl_cert_request_info.h"
39 #include "net/ssl/ssl_client_session_cache_openssl.h" 39 #include "net/ssl/ssl_client_session_cache_openssl.h"
40 #include "net/ssl/ssl_connection_status_flags.h" 40 #include "net/ssl/ssl_connection_status_flags.h"
41 #include "net/ssl/ssl_failure_state.h"
41 #include "net/ssl/ssl_info.h" 42 #include "net/ssl/ssl_info.h"
42 43
43 #if defined(OS_WIN) 44 #if defined(OS_WIN)
44 #include "base/win/windows_version.h" 45 #include "base/win/windows_version.h"
45 #endif 46 #endif
46 47
47 #if defined(USE_OPENSSL_CERTS) 48 #if defined(USE_OPENSSL_CERTS)
48 #include "net/ssl/openssl_client_key_store.h" 49 #include "net/ssl/openssl_client_key_store.h"
49 #else 50 #else
50 #include "net/ssl/openssl_platform_key.h" 51 #include "net/ssl/openssl_platform_key.h"
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 transport_bio_(NULL), 365 transport_bio_(NULL),
365 transport_(transport_socket.Pass()), 366 transport_(transport_socket.Pass()),
366 host_and_port_(host_and_port), 367 host_and_port_(host_and_port),
367 ssl_config_(ssl_config), 368 ssl_config_(ssl_config),
368 ssl_session_cache_shard_(context.ssl_session_cache_shard), 369 ssl_session_cache_shard_(context.ssl_session_cache_shard),
369 next_handshake_state_(STATE_NONE), 370 next_handshake_state_(STATE_NONE),
370 npn_status_(kNextProtoUnsupported), 371 npn_status_(kNextProtoUnsupported),
371 channel_id_sent_(false), 372 channel_id_sent_(false),
372 handshake_completed_(false), 373 handshake_completed_(false),
373 certificate_verified_(false), 374 certificate_verified_(false),
375 ssl_failure_state_(SSL_FAILURE_NONE),
374 transport_security_state_(context.transport_security_state), 376 transport_security_state_(context.transport_security_state),
375 policy_enforcer_(context.cert_policy_enforcer), 377 policy_enforcer_(context.cert_policy_enforcer),
376 net_log_(transport_->socket()->NetLog()), 378 net_log_(transport_->socket()->NetLog()),
377 weak_factory_(this) { 379 weak_factory_(this) {
378 DCHECK(cert_verifier_); 380 DCHECK(cert_verifier_);
379 } 381 }
380 382
381 SSLClientSocketOpenSSL::~SSLClientSocketOpenSSL() { 383 SSLClientSocketOpenSSL::~SSLClientSocketOpenSSL() {
382 Disconnect(); 384 Disconnect();
383 } 385 }
384 386
385 void SSLClientSocketOpenSSL::GetSSLCertRequestInfo( 387 void SSLClientSocketOpenSSL::GetSSLCertRequestInfo(
386 SSLCertRequestInfo* cert_request_info) { 388 SSLCertRequestInfo* cert_request_info) {
387 cert_request_info->host_and_port = host_and_port_; 389 cert_request_info->host_and_port = host_and_port_;
388 cert_request_info->cert_authorities = cert_authorities_; 390 cert_request_info->cert_authorities = cert_authorities_;
389 cert_request_info->cert_key_types = cert_key_types_; 391 cert_request_info->cert_key_types = cert_key_types_;
390 } 392 }
391 393
392 SSLClientSocket::NextProtoStatus SSLClientSocketOpenSSL::GetNextProto( 394 SSLClientSocket::NextProtoStatus SSLClientSocketOpenSSL::GetNextProto(
393 std::string* proto) const { 395 std::string* proto) const {
394 *proto = npn_proto_; 396 *proto = npn_proto_;
395 return npn_status_; 397 return npn_status_;
396 } 398 }
397 399
398 ChannelIDService* 400 ChannelIDService*
399 SSLClientSocketOpenSSL::GetChannelIDService() const { 401 SSLClientSocketOpenSSL::GetChannelIDService() const {
400 return channel_id_service_; 402 return channel_id_service_;
401 } 403 }
402 404
405 SSLFailureState SSLClientSocketOpenSSL::GetSSLFailureState() const {
406 return ssl_failure_state_;
407 }
408
403 int SSLClientSocketOpenSSL::ExportKeyingMaterial( 409 int SSLClientSocketOpenSSL::ExportKeyingMaterial(
404 const base::StringPiece& label, 410 const base::StringPiece& label,
405 bool has_context, const base::StringPiece& context, 411 bool has_context, const base::StringPiece& context,
406 unsigned char* out, unsigned int outlen) { 412 unsigned char* out, unsigned int outlen) {
407 if (!IsConnected()) 413 if (!IsConnected())
408 return ERR_SOCKET_NOT_CONNECTED; 414 return ERR_SOCKET_NOT_CONNECTED;
409 415
410 crypto::OpenSSLErrStackTracer err_tracer(FROM_HERE); 416 crypto::OpenSSLErrStackTracer err_tracer(FROM_HERE);
411 417
412 int rv = SSL_export_keying_material( 418 int rv = SSL_export_keying_material(
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 506
501 cert_authorities_.clear(); 507 cert_authorities_.clear();
502 cert_key_types_.clear(); 508 cert_key_types_.clear();
503 509
504 start_cert_verification_time_ = base::TimeTicks(); 510 start_cert_verification_time_ = base::TimeTicks();
505 511
506 npn_status_ = kNextProtoUnsupported; 512 npn_status_ = kNextProtoUnsupported;
507 npn_proto_.clear(); 513 npn_proto_.clear();
508 514
509 channel_id_sent_ = false; 515 channel_id_sent_ = false;
516 handshake_completed_ = false;
517 certificate_verified_ = false;
510 channel_id_request_handle_.Cancel(); 518 channel_id_request_handle_.Cancel();
519 ssl_failure_state_ = SSL_FAILURE_NONE;
511 } 520 }
512 521
513 bool SSLClientSocketOpenSSL::IsConnected() const { 522 bool SSLClientSocketOpenSSL::IsConnected() const {
514 // If the handshake has not yet completed. 523 // If the handshake has not yet completed.
515 if (!completed_connect_) 524 if (!completed_connect_)
516 return false; 525 return false;
517 // If an asynchronous operation is still pending. 526 // If an asynchronous operation is still pending.
518 if (user_read_buf_.get() || user_write_buf_.get()) 527 if (user_read_buf_.get() || user_write_buf_.get())
519 return true; 528 return true;
520 529
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 // If not done, stay in this state 942 // If not done, stay in this state
934 GotoState(STATE_HANDSHAKE); 943 GotoState(STATE_HANDSHAKE);
935 return ERR_IO_PENDING; 944 return ERR_IO_PENDING;
936 } 945 }
937 946
938 LOG(ERROR) << "handshake failed; returned " << rv << ", SSL error code " 947 LOG(ERROR) << "handshake failed; returned " << rv << ", SSL error code "
939 << ssl_error << ", net_error " << net_error; 948 << ssl_error << ", net_error " << net_error;
940 net_log_.AddEvent( 949 net_log_.AddEvent(
941 NetLog::TYPE_SSL_HANDSHAKE_ERROR, 950 NetLog::TYPE_SSL_HANDSHAKE_ERROR,
942 CreateNetLogOpenSSLErrorCallback(net_error, ssl_error, error_info)); 951 CreateNetLogOpenSSLErrorCallback(net_error, ssl_error, error_info));
952
953 // Classify the handshake failure. This is used to determine causes of the
954 // TLS version fallback.
955
956 // |cipher| is the current outgoing cipher suite, so it is non-null iff
957 // ChangeCipherSpec was sent.
958 const SSL_CIPHER* cipher = SSL_get_current_cipher(ssl_);
959 if (SSL_get_state(ssl_) == SSL3_ST_CR_SRVR_HELLO_A) {
960 ssl_failure_state_ = SSL_FAILURE_CLIENT_HELLO;
961 } else if (cipher && (SSL_CIPHER_get_id(cipher) ==
962 TLS1_CK_DHE_RSA_WITH_AES_128_GCM_SHA256 ||
963 SSL_CIPHER_get_id(cipher) ==
964 TLS1_CK_RSA_WITH_AES_128_GCM_SHA256)) {
965 ssl_failure_state_ = SSL_FAILURE_BUGGY_GCM;
966 } else if (cipher && ssl_config_.send_client_cert) {
967 ssl_failure_state_ = SSL_FAILURE_CLIENT_AUTH;
968 } else if (ERR_GET_LIB(error_info.error_code) == ERR_LIB_SSL &&
969 ERR_GET_REASON(error_info.error_code) ==
970 SSL_R_OLD_SESSION_VERSION_NOT_RETURNED) {
971 ssl_failure_state_ = SSL_FAILURE_SESSION_MISMATCH;
972 } else if (cipher && npn_status_ != kNextProtoUnsupported) {
973 ssl_failure_state_ = SSL_FAILURE_NEXT_PROTO;
974 } else {
975 ssl_failure_state_ = SSL_FAILURE_UNKNOWN;
976 }
943 } 977 }
944 978
945 GotoState(STATE_HANDSHAKE_COMPLETE); 979 GotoState(STATE_HANDSHAKE_COMPLETE);
946 return net_error; 980 return net_error;
947 } 981 }
948 982
949 int SSLClientSocketOpenSSL::DoHandshakeComplete(int result) { 983 int SSLClientSocketOpenSSL::DoHandshakeComplete(int result) {
950 if (result < 0) 984 if (result < 0)
951 return result; 985 return result;
952 986
(...skipping 961 matching lines...) Expand 10 before | Expand all | Expand 10 after
1914 } 1948 }
1915 return false; 1949 return false;
1916 } 1950 }
1917 1951
1918 scoped_refptr<X509Certificate> 1952 scoped_refptr<X509Certificate>
1919 SSLClientSocketOpenSSL::GetUnverifiedServerCertificateChain() const { 1953 SSLClientSocketOpenSSL::GetUnverifiedServerCertificateChain() const {
1920 return server_cert_; 1954 return server_cert_;
1921 } 1955 }
1922 1956
1923 } // namespace net 1957 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_openssl.h ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698