Add Chrome OS-specific controlled setting indicators

chrome/browser/policy/policy_prefs_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <map>
 #include <sstream>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/stl_util.h"
+#include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/mock_configuration_policy_provider.h"
 #include "chrome/browser/policy/policy_map.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 18 matching lines @@
   "chrome://settings-frame/passwords",
   "chrome://settings-frame/autofill",
   "chrome://settings-frame/content",
   "chrome://settings-frame/homePageOverlay",
   "chrome://settings-frame/languages",
 #if defined(OS_CHROMEOS)
   "chrome://settings-frame/accounts",
 #endif
 };
 
+const char kCrosSettingsPrefix[] = "cros.";
+
 // Contains the details of a single test case verifying that the controlled
 // setting indicators for a pref affected by a policy work correctly. This is
 // part of the data loaded from chrome/test/data/policy/policy_test_cases.json.
 class IndicatorTestCase {
  public:
   IndicatorTestCase(const base::DictionaryValue& policy,
                     const std::string& value,
                     bool readonly)
       : policy_(policy.DeepCopy()), value_(value), readonly_(readonly) {}
   ~IndicatorTestCase() {}
@@ skipping 431 matching lines @@
   ASSERT_TRUE(test_case);
   const ScopedVector<PrefMapping>& pref_mappings = test_case->pref_mappings();
   if (!test_case->IsSupported() || pref_mappings.empty())
     return;
   LOG(INFO) << "Testing policy: " << test_case->name();
 
   for (ScopedVector<PrefMapping>::const_iterator
            pref_mapping = pref_mappings.begin();
        pref_mapping != pref_mappings.end();
        ++pref_mapping) {
+    // Skip Chrome OS preferences that use a different backend and cannot be
+    // retrieved through the prefs mechanism.
+    if (StartsWithASCII((*pref_mapping)->pref(), kCrosSettingsPrefix, true))
+      continue;
+
     PrefService* prefs = (*pref_mapping)->is_local_state() ?
         g_browser_process->local_state() : browser()->profile()->GetPrefs();
     // The preference must have been registered.
     const PrefService::Preference* pref =
         prefs->FindPreference((*pref_mapping)->pref().c_str());
     ASSERT_TRUE(pref);
     prefs->ClearPref((*pref_mapping)->pref().c_str());
 
     // Verify that setting the policy overrides the pref.
     const PolicyMap kNoPolicies;
@@ skipping 57 matching lines @@
   LOG(INFO) << "Testing policy: " << policy_test_case->name();
 
   for (ScopedVector<PrefMapping>::const_iterator
            pref_mapping = pref_mappings.begin();
        pref_mapping != pref_mappings.end();
        ++pref_mapping) {
     const ScopedVector<IndicatorTestCase>&
         indicator_test_cases = (*pref_mapping)->indicator_test_cases();
     if (indicator_test_cases.empty())
       continue;
-    PrefService* prefs = (*pref_mapping)->is_local_state() ?
-        g_browser_process->local_state() : browser()->profile()->GetPrefs();
-    // The preference must have been registered.
-    const PrefService::Preference* pref =
-        prefs->FindPreference((*pref_mapping)->pref().c_str());
-    ASSERT_TRUE(pref);
 
     ui_test_utils::NavigateToURL(browser(), GURL(kSettingsPages[0]));
     if (!(*pref_mapping)->indicator_test_setup_js().empty()) {
       ASSERT_TRUE(content::ExecuteJavaScript(
           chrome::GetActiveWebContents(browser())->GetRenderViewHost(), L"",
           (*pref_mapping)->indicator_test_setup_js()));
     }
 
     std::string indicator_selector = (*pref_mapping)->indicator_selector();
     if (indicator_selector.empty())
@@ skipping 10 matching lines @@
                                         "", "", false);
       // Check that the appropriate controlled setting indicator is shown when a
       // value is enforced by policy.
       policies.LoadFrom(&(*indicator_test_case)->policy(),
                         POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER);
       provider_.UpdateChromePolicy(policies);
       VerifyControlledSettingIndicators(browser(), indicator_selector,
                                         (*indicator_test_case)->value(),
                                         "policy",
                                         (*indicator_test_case)->readonly());
+
       if (!policy_test_case->can_be_recommended())
         continue;
+
+      PrefService* prefs = (*pref_mapping)->is_local_state() ?
+          g_browser_process->local_state() : browser()->profile()->GetPrefs();
+      // The preference must have been registered.
+      const PrefService::Preference* pref =
+          prefs->FindPreference((*pref_mapping)->pref().c_str());
+      ASSERT_TRUE(pref);
+
       // Check that the appropriate controlled setting indicator is shown when a
       // value is recommended by policy and the user has not overridden the
       // recommendation.
       policies.LoadFrom(&(*indicator_test_case)->policy(),
                         POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER);
       provider_.UpdateChromePolicy(policies);
       VerifyControlledSettingIndicators(browser(), indicator_selector,
                                         (*indicator_test_case)->value(),
                                         "recommended",
                                         (*indicator_test_case)->readonly());
@@ skipping 10 matching lines @@
   }
 }
 
 INSTANTIATE_TEST_CASE_P(
     PolicyPrefsTestInstance,
     PolicyPrefsTest,
     testing::ValuesIn(GetChromePolicyDefinitionList()->begin,
                       GetChromePolicyDefinitionList()->end));
 
 }  // namespace policy