Issue 1127593004: Revert of Remove unnecessary ternaries to improve readability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127593004: Revert of Remove unnecessary ternaries to improve readability. (Closed)

Created:
5 years, 7 months ago by piman

Modified:
5 years, 7 months ago

Reviewers:
danakj, Thiemo Nagel

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Remove unnecessary ternaries to improve readability. (patchset #1 id:1 of https://codereview.chromium.org/1128513002/) Reason for revert: Compile errors - http://build.chromium.org/p/chromium/buildstatus?builder=Win&number=31603 Original issue's description: > Remove unnecessary ternaries to improve readability. > > BUG=None > > Committed: https://crrev.com/d358dccf326b51d60b72292bae9f73cdd1475bcf > Cr-Commit-Position: refs/heads/master@{#328388} TBR=danakj@chromium.org,tnagel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/2ac89dd3c312af5fb7950803594986b50dcc5c91 Cr-Commit-Position: refs/heads/master@{#328392}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	base/logging.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

piman

Created Revert of Remove unnecessary ternaries to improve readability.

5 years, 7 months ago (2015-05-05 20:23:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127593004/1

5 years, 7 months ago (2015-05-05 20:24:48 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-05 20:27:11 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2ac89dd3c312af5fb7950803594986b50dcc5c91
Cr-Commit-Position: refs/heads/master@{#328392}