Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1127553002: [chrome/browser/local_discovery] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/local_discovery module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/1a20d357839cd60272648164ed9f2167505b5b54 Cr-Commit-Position: refs/heads/master@{#328275}

Patch Set 1 #

Patch Set 2 : Fixed Build break : Dependency in components/wifi classes #

Messages

Total messages: 12 (5 generated)
Pranay
PTAL, Thanks
5 years, 7 months ago (2015-05-04 09:17:26 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 7 months ago (2015-05-04 15:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127553002/1
5 years, 7 months ago (2015-05-04 17:27:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/49506)
5 years, 7 months ago (2015-05-04 17:47:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127553002/20001
5 years, 7 months ago (2015-05-05 03:33:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-05 04:39:58 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 04:40:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a20d357839cd60272648164ed9f2167505b5b54
Cr-Commit-Position: refs/heads/master@{#328275}

Powered by Google App Engine
This is Rietveld 408576698