Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1127543003: Revert of Reland "Wrap v8natives.js into a function." (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
Yang, Jakob Kummerow
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Wrap v8natives.js into a function." (patchset #2 id:20001 of https://codereview.chromium.org/1123703002/) Reason for revert: [Sheriff] Speculative revert for braking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314 (reverted already titzer's CL which didn't help) Original issue's description: > Reland "Wrap v8natives.js into a function." > > Committed: https://crrev.com/72ab42172979b60a1b784ea0c6a495d7ee2bba67 > Cr-Commit-Position: refs/heads/master@{#28193} TBR=jkummerow@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6afc0dcbfccfb27dc05dce78ceff0ba77ecded07 Cr-Commit-Position: refs/heads/master@{#28208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -444 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/array.js View 9 chunks +10 lines, -10 lines 0 comments Download
M src/array-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/collection.js View 6 chunks +8 lines, -8 lines 0 comments Download
M src/collection-iterator.js View 2 chunks +6 lines, -6 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/generator.js View 2 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-array.js View 5 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 3 chunks +4 lines, -9 lines 0 comments Download
M src/i18n.js View 28 chunks +61 lines, -60 lines 0 comments Download
M src/json.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 12 chunks +15 lines, -23 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/object-observe.js View 6 chunks +9 lines, -9 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string-iterator.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/symbol.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 7 chunks +35 lines, -41 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 14 chunks +180 lines, -209 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/jsmin.py View 7 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Reland "Wrap v8natives.js into a function."
5 years, 7 months ago (2015-05-04 16:49:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127543003/1
5 years, 7 months ago (2015-05-04 16:49:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 16:49:57 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 16:50:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6afc0dcbfccfb27dc05dce78ceff0ba77ecded07
Cr-Commit-Position: refs/heads/master@{#28208}

Powered by Google App Engine
This is Rietveld 408576698