Add Map.unmodifiable constructor.

sdk/lib/_internal/compiler/js_lib/constant_map.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of _js_helper;
 
+class ConstantMapView<K, V> extends UnmodifiableMapView
+                      implements ConstantMap {
+ ConstantMapView(Map base) : super(base);

[sra1, 2015/05/07 19:24:42]

indentation

+}
+
 abstract class ConstantMap<K, V> implements Map<K, V> {
+  // Used to create unmodifiable maps from other maps.
+  factory ConstantMap.from(Map other) {

[sra1, 2015/05/07 19:24:41]

Under what conditions can you return 'other'?
Or create a new instance to capture K,V but otherwise share structure?

+    List keys = other.keys.toList();
+    bool allStrings = true;
+    for (var k in keys) {
+      if (k is! String) {
+        allStrings = false;
+        break;
+      }
+    }
+    if (allStrings) {
+      bool containsProto = false;
+      var protoValue = null;
+      var object = JS('=Object', '{}');
+      int length = 0;
+      for (var k in keys) {
+        var v = other[k];
+        if (k != "__proto__") {

[sra1, 2015/05/07 19:24:42]

Use single quotes for consistency with rest of file,

+          if (!jsHasOwnProperty(object, k)) length++;
+          JS("void", "#[#] = #", object, k, v);

[sra1, 2015/05/07 19:24:42]

ditto

+        } else {
+          containsProto = true;
+          protoValue = v;
+        }
+      }
+      if (containsProto) {
+        length++;
+        return new ConstantProtoMap<K, V>._(length, object, keys, protoValue);
+      }
+      return new ConstantStringMap<K, V>._(length, object, keys);
+    }
+    // TODO(lrn): Make a proper unmodifiable map implementation.
+    return new ConstantMapView<K, V>(new Map.from(other));
+  }
+
   const ConstantMap._();
 
   bool get isEmpty => length == 0;
 
   bool get isNotEmpty => !isEmpty;
 
   String toString() => Maps.mapToString(this);
 
-  _throwUnmodifiable() {
+  static _throwUnmodifiable() {
     throw new UnsupportedError("Cannot modify unmodifiable Map");
   }
   void operator []=(K key, V val) => _throwUnmodifiable();
   V putIfAbsent(K key, V ifAbsent()) => _throwUnmodifiable();
   V remove(K key) => _throwUnmodifiable();
   void clear() => _throwUnmodifiable();
   void addAll(Map<K, V> other) => _throwUnmodifiable();
 }
 
 class ConstantStringMap<K, V> extends ConstantMap<K, V>
                               implements _symbol_dev.EfficientLength {
 
-  // This constructor is not used.  The instantiation is shortcut by the
-  // compiler. It is here to make the uninitialized final fields legal.
+  // This constructor is not used for actual compile-time constants.
+  // The instantiation of constant maps is shortcut by the compiler.
   const ConstantStringMap._(this.length, this._jsObject, this._keys)
       : super._();
 
   final int length;
   // A constant map is backed by a JavaScript object.
   final _jsObject;
   final List<K> _keys;
 
   bool containsValue(V needle) {
     return values.any((V value) => value == needle);
@@ skipping 99 matching lines @@
   Iterable<K> get keys {
     return _getMap().keys;
   }
 
   Iterable<V> get values {
     return _getMap().values;
   }
 
   int get length => _getMap().length;
 }