Change the names of the NaCl IRT files to solve ChromeOS packaging issue.

Change the names of the NaCl IRT files to solve ChromeOS packaging issue.
The old SRPC IRT nexes now take the form 'nacl_irt_srpc_*', while the new IPC
IRT nexes take the form 'nacl_irt_*'.
BUG=116317, 160316
TEST=builds
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167787

[bbudge, 2012-11-14 22:51:07]

Mark, can this land before I roll out my change to src-internal and re-roll
DEPS?

[brettw, 2012-11-14 22:53:45]

lgtm for anything I'm owner of

[Mark Seaborn, 2012-11-14 23:06:07]

On 14 November 2012 14:51, <bbudge@chromium.org> wrote:

> Reviewers: brettw, Mark Seaborn,
>
> Message:
> Mark, can this land before I roll out my change to src-internal and re-roll
> DEPS?
>

Yes, I think so, because in
https://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=30718you
have an "if [ -f foo ]" check, so it will work if the files are not
present because they have been renamed:

--- internal/common/installer.include	(revision 30004)
+++ internal/common/installer.include	(working copy)
@@ -190,7 +190,10 @@
   # certainly resets the OSABI and ABIVERSION fields to non-NaCl values,
   # although the NaCl IRT loader doesn't care about these fields.  In any
   # case, the IRT binaries are already stripped by NaCl's build process.
-  for filename in nacl_irt_x86_32.nexe nacl_irt_x86_64.nexe; do
+  for filename in nacl_irt_x86_32.nexe \
+                  nacl_irt_x86_64.nexe \
+                  nacl_ipc_irt_x86_32.nexe \
+                  nacl_ipc_irt_x86_64.nexe; do
     if [ -f "${BUILDDIR}/$filename" ]; then
       install -m 644 "${BUILDDIR}/$filename" "${STAGEDIR}/${INSTALLDIR}/"
     fi

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Mark Seaborn, 2012-11-14 23:06:09]

On 14 November 2012 14:51, <bbudge@chromium.org> wrote:

> Reviewers: brettw, Mark Seaborn,
>
> Message:
> Mark, can this land before I roll out my change to src-internal and re-roll
> DEPS?
>

Yes, I think so, because in
https://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=30718you
have an "if [ -f foo ]" check, so it will work if the files are not
present because they have been renamed:

--- internal/common/installer.include	(revision 30004)
+++ internal/common/installer.include	(working copy)
@@ -190,7 +190,10 @@
   # certainly resets the OSABI and ABIVERSION fields to non-NaCl values,
   # although the NaCl IRT loader doesn't care about these fields.  In any
   # case, the IRT binaries are already stripped by NaCl's build process.
-  for filename in nacl_irt_x86_32.nexe nacl_irt_x86_64.nexe; do
+  for filename in nacl_irt_x86_32.nexe \
+                  nacl_irt_x86_64.nexe \
+                  nacl_ipc_irt_x86_32.nexe \
+                  nacl_ipc_irt_x86_64.nexe; do
     if [ -f "${BUILDDIR}/$filename" ]; then
       install -m 644 "${BUILDDIR}/$filename" "${STAGEDIR}/${INSTALLDIR}/"
     fi

Mark

[Mark Seaborn, 2012-11-14 23:11:50]

LGTM, though I didn't check whether you got all the references :-)