Count per check hits in ICData.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 2835 matching lines @@
                 const Function& target) const;
   // Adds sorted so that Smi is the first class-id. Use only for
   // num_args_tested == 1.
   void AddReceiverCheck(intptr_t receiver_class_id,
                         const Function& target) const;
 
   // Retrieving checks.
 
   void GetCheckAt(intptr_t index,
                   GrowableArray<intptr_t>* class_ids,
-                  Function* target) const;
+                  Function* target,
+                  intptr_t* count = NULL) const;

[srdjan, 2012/11/13 20:58:14]

Maybe it is OK if this method remains unchanged and use GetCountAt to access
counts?

[Kevin Millikin (Google), 2012/11/13 20:59:33]

I'm not thrilled with the default parameter.  It looks like some call sites
don't use target either, but we always pass it.  So it's at least inconsistent
this way.

[Vyacheslav Egorov (Google), 2012/12/17 12:54:16]

Done.

   void GetOneClassCheckAt(intptr_t index,
                           intptr_t* class_id,
                           Function* target) const;
   intptr_t GetReceiverClassIdAt(intptr_t index) const;
   intptr_t GetClassIdAt(intptr_t index, intptr_t arg_nr) const;
 
   RawFunction* GetTargetAt(intptr_t index) const;
   RawFunction* GetTargetForReceiverClassId(intptr_t class_id) const;
 
+  intptr_t GetCountAt(intptr_t index) const;
+
   // Returns this->raw() if num_args_tested == 1 and arg_nr == 1, otherwise
   // returns a new ICData object containing only unique arg_nr checks.
   RawICData* AsUnaryClassChecksForArgNr(intptr_t arg_nr) const;
   RawICData* AsUnaryClassChecks() const {
     return AsUnaryClassChecksForArgNr(0);
   }
 
   bool AllTargetsHaveSameOwner(intptr_t owner_cid) const;
   bool AllReceiversAreNumbers() const;
   bool HasOneTarget() const;
 
   static RawICData* New(const Function& caller_function,
                         const String& target_name,
                         intptr_t deopt_id,
                         intptr_t num_args_tested);
 
+  static intptr_t TestEntryLengthFor(intptr_t num_args);
+
+  static intptr_t TargetIndexFor(intptr_t num_args) {

[Kevin Millikin (Google), 2012/11/13 20:59:33]

Not an Index, but an Offset (from the beginning of the entry).

[Vyacheslav Egorov (Google), 2012/12/17 12:54:16]

Done.

+    return num_args;
+  }
+
+  static intptr_t CountIndexFor(intptr_t num_args) {
+    return num_args + 1;
+  }
+
  private:
   RawArray* ic_data() const {
     return raw_ptr()->ic_data_;
   }
 
   void set_function(const Function& value) const;
   void set_target_name(const String& value) const;
   void set_deopt_id(intptr_t value) const;
   void set_num_args_tested(intptr_t value) const;
   void set_ic_data(const Array& value) const;
@@ skipping 3003 matching lines @@
     if (this->CharAt(i) != str.CharAt(begin_index + i)) {
       return false;
     }
   }
   return true;
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_