Avoid setting activeTexture redundantly

Avoid setting activeTexture redundantly

We use GL_TEXTURE0 for nearly all operations, so it's cheaper to leave this as the default
for all draws and have quads that use other texture units reset to 0.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167030

[jamesr, 2012-11-09 00:19:11]

If we like the harness I could use it for future redundant state patches.  Do we
want to have one harness+test for each bit of state we care 'bout, or do you
think it's OK to just have one test that checks all state?

[enne (OOO), 2012-11-09 06:14:55]

The bad part about one test is that it makes failure a lot more opaque.  Maybe
you could have a RedundantStateTest fixture that sets up everything and all you
have to do is overload a function or two.

https://codereview.chromium.org/11275222/diff/3001/cc/cc_tests.gyp
File cc/cc_tests.gyp (right):

https://codereview.chromium.org/11275222/diff/3001/cc/cc_tests.gyp#newcode83
cc/cc_tests.gyp:83: 'test/render_pass_test_common.cc',
Looks like you're missing this file.

https://codereview.chromium.org/11275222/diff/3001/cc/gl_renderer_unittest.cc
File cc/gl_renderer_unittest.cc (right):

https://codereview.chromium.org/11275222/diff/3001/cc/gl_renderer_unittest.cc...
cc/gl_renderer_unittest.cc:492: : m_activeTexture(GL_TEXTURE1)
Maybe this should be GL_INVALID (or whatever the bogus enum is) just to avoid
any future reordering issues?

[jamesr, 2012-11-09 21:06:22]

PTAL

I think one test with specific EXPECT_EQs should be pretty clear since the test
output will say which bit(s) of state are being messed up.  After this I'll try
expanding the test to cover other state (I think scissor rect and blend are
next) and see how that works.

[enne (OOO), 2012-11-09 21:09:34]

lgtm

[commit-bot: I haz the power, 2012-11-09 21:57:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11275222/3015

[commit-bot: I haz the power, 2012-11-09 22:21:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11275222/11003

[commit-bot: I haz the power, 2012-11-09 22:37:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11275222/4013

[commit-bot: I haz the power, 2012-11-10 01:32:54]

Change committed as 167030