Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 11275218: Force a new download/install of git-1.8.0 to pick up: (Closed)

Created:
8 years, 1 month ago by szager
Modified:
8 years, 1 month ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M bootstrap/win/win_tools.bat View 1 3 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
szager
8 years, 1 month ago (2012-11-08 23:02:23 UTC) #1
cmp
lgtm https://codereview.chromium.org/11275218/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/11275218/diff/1/bootstrap/win/win_tools.bat#newcode40 bootstrap/win/win_tools.bat:40: goto :GIT_INSTALL I think now (or RSN) would ...
8 years, 1 month ago (2012-11-08 23:04:49 UTC) #2
szager1
8 years, 1 month ago (2012-11-08 23:40:46 UTC) #3
On 2012/11/08 23:04:49, cmp wrote:
> lgtm
> 
> https://codereview.chromium.org/11275218/diff/1/bootstrap/win/win_tools.bat
> File bootstrap/win/win_tools.bat (right):
> 
>
https://codereview.chromium.org/11275218/diff/1/bootstrap/win/win_tools.bat#n...
> bootstrap/win/win_tools.bat:40: goto :GIT_INSTALL
> I think now (or RSN) would be a good time to standardize this with a version
> field in a file that is unpacked from git_bin.zip.  WDYT?

RSN :)

Powered by Google App Engine
This is Rietveld 408576698