Source/WebKit/chromium/src/DateTimeChooserImpl.cpp - Issue 11275190: Merge 133132 - [Chromium] Page popup shows up at wrong locations when root view is scrolled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/DateTimeChooserImpl.cpp

Issue 11275190: Merge 133132 - [Chromium] Page popup shows up at wrong locations when root view is scrolled (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebKit/chromium/src/DateTimeChooserImpl.cpp

===================================================================

--- Source/WebKit/chromium/src/DateTimeChooserImpl.cpp (revision 133742)

+++ Source/WebKit/chromium/src/DateTimeChooserImpl.cpp (working copy)

@@ -93,6 +93,7 @@

FrameView* view = static_cast<WebViewImpl*>(m_chromeClient->webView())->page()->mainFrame()->view();

IntRect rootViewVisibleContentRect = view->visibleContentRect(true /* include scrollbars */);

IntRect rootViewRectInScreen = m_chromeClient->rootViewToScreen(rootViewVisibleContentRect);

+ rootViewRectInScreen.move(-view->scrollX(), -view->scrollY());

addString("<!DOCTYPE html><head><meta charset='UTF-8'><style>\n", writer);

writer.addData(WebCore::pickerCommonCss, sizeof(WebCore::pickerCommonCss));

« no previous file with comments | « Source/WebKit/chromium/ChangeLog ('k') | no next file » | no next file with comments »