Collect stack trace on stack overflow.

Collect stack trace on stack overflow.

BUG=v8:2394
Committed: https://code.google.com/p/v8/source/detail?r=12933

[Yang, 2012-11-07 11:02:38]

PTAL.

http://codereview.chromium.org/11275186/diff/1/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/11275186/diff/1/src/isolate.cc#newcode561
src/isolate.cc:561: // yet.
This part is simply moved over from runtime.cc

[Yang, 2012-11-09 10:56:34]

On 2012/11/07 11:02:38, Yang wrote:
> PTAL.
> 
> http://codereview.chromium.org/11275186/diff/1/src/isolate.cc
> File src/isolate.cc (right):
> 
> http://codereview.chromium.org/11275186/diff/1/src/isolate.cc#newcode561
> src/isolate.cc:561: // yet.
> This part is simply moved over from runtime.cc

Now that Error.message has been fixed, please take a look at this.

[Sven Panne, 2012-11-09 12:25:52]

LGTM with nits

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc
File src/isolate.cc (right):

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode562
src/isolate.cc:562: bool ShowFrameInStackTrace(StackFrame* raw_frame,
Make this static or a method of StackFrame. Furthermore, the name should make it
clearer that this is a predicate, e.g. IsVisibleInStackTrace.

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode566
src/isolate.cc:566: if (!raw_frame->is_java_script()) {
Just for consistency: One-liner if...

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode572
src/isolate.cc:572: if (!raw_fun->IsJSFunction()) {
Again just for consistency: One-liner if...

http://codereview.chromium.org/11275186/diff/10/src/isolate.cc#newcode611
src/isolate.cc:611: while (!iter.done() && frames_seen < limit) {
A for-loop with a conditional break in it might be more readable.