Disable ASan instrumentation of globals on Android.

Disable ASan instrumentation of globals on Android.

BUG=137569, 159801
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166391

[Alexander Potapenko, 2012-11-07 10:51:22]

Please file a bug to track this.
On Nov 7, 2012 1:59 PM, <eugenis@chromium.org> wrote:

> Reviewers: bulach, Alexander Potapenko,
>
> Description:
> Disable ASan instrumentation of globals on Android.
>
> Please review this at
https://codereview.chromium.**org/11275185/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     build/common.gypi
>
>
> Index: build/common.gypi
> ==============================**==============================**=======
> --- build/common.gypi   (revision 166212)
> +++ build/common.gypi   (working copy)
> @@ -2857,6 +2857,15 @@
>                    }],
>                  ],
>                }],
> +              ['asan==1', {
> +                'cflags': [
> +                  # Android build relies on -Wl,--gc-sections removing
> +                  # unreachable code. ASan instrumentation for globals
> inhibits
> +                  # this and results in a library with unresolvable
> relocations.
> +                  # TODO(eugenis): find a way to reenable this.
> +                  '-mllvm -asan-globals=0',
> +                ],
> +              }],
>                ['android_build_type==0', {
>                  'defines': [
>                    # The NDK has these things, but doesn't define the
> constants
>
>
>

[Alexander Potapenko, 2012-11-07 10:52:10]

LGTM otherwise
On Nov 7, 2012 1:59 PM, <eugenis@chromium.org> wrote:

> Reviewers: bulach, Alexander Potapenko,
>
> Description:
> Disable ASan instrumentation of globals on Android.
>
> Please review this at
https://codereview.chromium.**org/11275185/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     build/common.gypi
>
>
> Index: build/common.gypi
> ==============================**==============================**=======
> --- build/common.gypi   (revision 166212)
> +++ build/common.gypi   (working copy)
> @@ -2857,6 +2857,15 @@
>                    }],
>                  ],
>                }],
> +              ['asan==1', {
> +                'cflags': [
> +                  # Android build relies on -Wl,--gc-sections removing
> +                  # unreachable code. ASan instrumentation for globals
> inhibits
> +                  # this and results in a library with unresolvable
> relocations.
> +                  # TODO(eugenis): find a way to reenable this.
> +                  '-mllvm -asan-globals=0',
> +                ],
> +              }],
>                ['android_build_type==0', {
>                  'defines': [
>                    # The NDK has these things, but doesn't define the
> constants
>
>
>

[eugenis, 2012-11-07 11:07:55]

On 2012/11/07 10:52:10, Alexander Potapenko wrote:
> LGTM otherwise
> On Nov 7, 2012 1:59 PM, <mailto:eugenis@chromium.org> wrote:
> 
> > Reviewers: bulach, Alexander Potapenko,
> >
> > Description:
> > Disable ASan instrumentation of globals on Android.
> >
> > Please review this at
>
https://codereview.chromium.**org/11275185/%3Chttps://codereview.chromium.org...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
> >
> > Affected files:
> >   M     build/common.gypi
> >
> >
> > Index: build/common.gypi
> > ==============================**==============================**=======
> > --- build/common.gypi   (revision 166212)
> > +++ build/common.gypi   (working copy)
> > @@ -2857,6 +2857,15 @@
> >                    }],
> >                  ],
> >                }],
> > +              ['asan==1', {
> > +                'cflags': [
> > +                  # Android build relies on -Wl,--gc-sections removing
> > +                  # unreachable code. ASan instrumentation for globals
> > inhibits
> > +                  # this and results in a library with unresolvable
> > relocations.
> > +                  # TODO(eugenis): find a way to reenable this.
> > +                  '-mllvm -asan-globals=0',
> > +                ],
> > +              }],
> >                ['android_build_type==0', {
> >                  'defines': [
> >                    # The NDK has these things, but doesn't define the
> > constants
> >
> >
> >

http://code.google.com/p/chromium/issues/detail?id=159801

[bulach, 2012-11-07 11:33:54]

lgtm, thanks!