Fix length computation in Dart_StringToUTF8.

bin/builtin_natives.cc

Index: bin/builtin_natives.cc
===================================================================
--- bin/builtin_natives.cc	(revision 14418)
+++ bin/builtin_natives.cc	(working copy)
@@ -103,17 +103,16 @@
 // test/debug functionality in standalone dart mode.
 
 void Builtin::PrintString(FILE* out, Dart_Handle str) {
-  const char* chars = NULL;
-
-  Dart_Handle result = Dart_StringToCString(str, &chars);
+  intptr_t length = 0;
+  uint8_t* chars = NULL;
+  Dart_Handle result = Dart_StringToUTF8(str, &chars, &length);
   if (Dart_IsError(result)) {
     // TODO(turnidge): Consider propagating some errors here.  What if
     // an isolate gets interrupted by the embedder in the middle of
-    // Dart_StringToBytes?  We need to make sure not to swallow the
+    // Dart_StringToUTF8?  We need to make sure not to swallow the
     // interrupt.

[Bill Hesse, 2012/11/02 09:16:00]

I agree that errors should be propagated.  I believe that just replacing the
print with PropagateError(result) would give better behavior.

[siva, 2012/11/06 01:35:22]

Agree but probably should be done in a different CL as it requires signature
changes etc.

On 2012/11/02 09:16:00, Bill Hesse wrote:

     fputs(Dart_GetError(result), out);
   } else {
-    intptr_t length = strlen(chars);
     fwrite(chars, sizeof(*chars), length, out);
   }
   fputc('\n', out);