Merge SourceLocation and Source

lib/compiler/implementation/source_file.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('source_file');
 
 #import('dart:math');
 
 #import('colors.dart', prefix: 'colors');
 
 /**
  * Represents a file of source code.
  */
 class SourceFile {
 
   /** The name of the file. */
   final String filename;
 
   /** The text content of the file. */
   final String text;
 
   List<int> _lineStarts;
 
   SourceFile(this.filename, this.text);
 
   List<int> get lineStarts {
     if (_lineStarts == null) {
       var starts = [0];
-      var index = 0;
-      while (index < text.length) {
-        index = text.indexOf('\n', index) + 1;
-        if (index <= 0) break;
-        starts.add(index);
+      for (Match match in const RegExp("\r\n?|\n\r?").allMatches(text)) {
+        starts.add(match.start + 1);

[ahe, 2012/11/01 13:05:22]

What is the performance overhead of this? Perhaps the scanner should record this
information.

[Johnni Winther, 2012/11/01 15:27:13]

Enormous. I'll revert.

       }
       starts.add(text.length + 1);
       _lineStarts = starts;
     }
     return _lineStarts;
   }
 
   int getLine(int position) {
     List<int> starts = lineStarts;
     if (position < 0 || starts.last <= position) {
@@ skipping 52 matching lines @@
       }
 
       for (; i < toColumn; i++) {
         buf.add(color('^'));
       }
     }
 
     return buf.toString();
   }
 }