ui/gfx/rect_unittest.cc - Issue 11275089: SkRect to gfx::Rect type conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/rect_unittest.cc

Issue 11275089: SkRect to gfx::Rect type conversions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Use ToFlooredRectDeprecated and revert Transform API change Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/rect_unittest.cc

diff --git a/ui/gfx/rect_unittest.cc b/ui/gfx/rect_unittest.cc

index b83d8a466b432019e3d396d10cbc2e1b916f82a7..be1353debb09774720f4248ffdc3fa35aae82ce0 100644

--- a/ui/gfx/rect_unittest.cc

+++ b/ui/gfx/rect_unittest.cc

@@ -395,10 +395,10 @@ TEST(RectTest, SharesEdgeWith) {

EXPECT_FALSE(r.SharesEdgeWith(just_right_no_edge));

}

-TEST(RectTest, SkRectToRect) {

+TEST(RectTest, SkIRectToRect) {

gfx::Rect src(10, 20, 30, 40);

- SkRect skrect = gfx::RectToSkRect(src);

- EXPECT_EQ(src, gfx::SkRectToRect(skrect));

+ SkIRect skrect = gfx::RectToSkIRect(src);

+ EXPECT_EQ(src, gfx::SkIRectToRect(skrect));

}

// Similar to EXPECT_FLOAT_EQ, but lets NaN equal NaN