Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: ui/gfx/transform.cc

Issue 11275089: SkRect to gfx::Rect type conversions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove unnecessary lines Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/transform.cc
diff --git a/ui/gfx/transform.cc b/ui/gfx/transform.cc
index d34c9076f1d5d19a9403725fe059d444f55b1205..6c38ed4cd798581c96aeea484ec5e27aef697fbb 100644
--- a/ui/gfx/transform.cc
+++ b/ui/gfx/transform.cc
@@ -6,6 +6,7 @@
#include "ui/gfx/point3_f.h"
#include "ui/gfx/rect.h"
+#include "ui/gfx/rect_conversions.h"
#include "ui/gfx/safe_integer_conversions.h"
#include "ui/gfx/skia_util.h"
@@ -155,7 +156,7 @@ void Transform::TransformRect(Rect* rect) const {
SkRect src = RectToSkRect(*rect);
const SkMatrix& matrix = matrix_;
matrix.mapRect(&src);
- *rect = SkRectToRect(src);
+ *rect = gfx::ToFlooredRectDeprecated(SkRectToRectF(src));
sky 2012/11/01 16:10:24 The plan was to remove ToFlooredRectDeprecated. If
danakj 2012/11/01 16:38:21 IMO it's more a matter of making existing code tha
danakj 2012/11/01 17:38:27 I guess these methods need to take a RectF then, a
}
bool Transform::TransformRectReverse(Rect* rect) const {
@@ -165,7 +166,7 @@ bool Transform::TransformRectReverse(Rect* rect) const {
const SkMatrix& matrix = inverse;
SkRect src = RectToSkRect(*rect);
matrix.mapRect(&src);
- *rect = SkRectToRect(src);
+ *rect = gfx::ToFlooredRectDeprecated(SkRectToRectF(src));
return true;
}

Powered by Google App Engine
This is Rietveld 408576698