SkRect to gfx::Rect type conversions.

ui/gfx/transform.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_TRANSFORM_H_
 #define UI_GFX_TRANSFORM_H_
 
 #include "third_party/skia/include/utils/SkMatrix44.h"
 #include "ui/base/ui_export.h"
 
 namespace gfx {
 
 class Rect;
+class RectF;
 class Point;
 class Point3F;
 
 // 4x4 transformation matrix. Transform is cheap and explicitly allows
 // copy/assign.
 class UI_EXPORT Transform {
  public:
   Transform();
   ~Transform();
 
@@ skipping 71 matching lines @@
   // transformation can be inverted.
   bool TransformPointReverse(Point3F& point) const;
 
   // Applies the reverse transformation on the point. Returns true if the
   // transformation can be inverted. Rounds the result to the nearest point.
   bool TransformPointReverse(Point& point) const;
 
   // Applies transformation on the rectangle. Returns true if the transformed
   // rectangle was axis aligned. If it returns false, rect will be the
   // smallest axis aligned bounding box containing the transformed rect.
+  void TransformRect(RectF* rect) const;

[danakj, 2012/11/01 00:37:00]

Why the transform changes in this CL? I think they should be separate. As we're
not using ui::transform in cc/ at all right now, it seems like a separate
concern?

+
+  // Same as above, but expands to enclosing int rect.

[danakj, 2012/11/01 00:37:00]

Not sure if implicit enclosing is great either. I like the forced-to-be-explicit
nature of the other geometry things when going from float to int.

   void TransformRect(Rect* rect) const;
 
   // Applies the reverse transformation on the rectangle. Returns true if
   // the transformed rectangle was axis aligned. If it returns false,
   // rect will be the smallest axis aligned bounding box containing the
   // transformed rect.
-  bool TransformRectReverse(Rect* rect) const;
+  bool TransformRectReverse(RectF* rect) const;
+
+  // Same as above, but expands to enclosing int rect.
+  void TransformRectReverse(Rect* rect) const;
 
   // Returns the underlying matrix.
   const SkMatrix44& matrix() const { return matrix_; }
   SkMatrix44& matrix() { return matrix_; }
 
  private:
   void TransformPointInternal(const SkMatrix44& xform,
                               Point& point) const;
 
   void TransformPointInternal(const SkMatrix44& xform,
                               Point3F& point) const;
 
   SkMatrix44 matrix_;
 
   // copy/assign are allowed.
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_TRANSFORM_H_