Perform install tasks for newly installed or upgraded component apps/extensions.

chrome/browser/extensions/component_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/component_loader.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/path_service.h"
@@ skipping 26 matching lines @@
 
 #if defined(USE_ASH)
 #include "grit/chromium_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #endif
 
 namespace extensions {
 
 namespace {
 
+static bool enable_background_extenstions_during_testing = false;
+
 std::string GenerateId(const DictionaryValue* manifest, const FilePath& path) {
   std::string raw_key;
   std::string id_input;
   std::string id;
   CHECK(manifest->GetString(extension_manifest_keys::kPublicKey, &raw_key));
   CHECK(Extension::ParsePEMKeyBytes(raw_key, &id_input));
   CHECK(Extension::GenerateId(id_input, &id));
   return id;
 }
 
@@ skipping 133 matching lines @@
       info.root_directory,
       Extension::COMPONENT,
       *info.manifest,
       flags,
       &error));
   if (!extension.get()) {
     LOG(ERROR) << error;
     return NULL;
   }
   CHECK_EQ(info.extension_id, extension->id()) << extension->name();
-  extension_service_->AddExtension(extension);
+  extension_service_->AddComponentExtension(extension);
   return extension;
 }
 
 void ComponentLoader::Remove(const FilePath& root_directory) {
   // Find the ComponentExtensionInfo for the extension.
   RegisteredComponentExtensions::iterator it = component_extensions_.begin();
   for (; it != component_extensions_.end(); ++it) {
     if (it->root_directory == root_directory) {
       Remove(GenerateId(it->manifest, root_directory));
       break;
@@ skipping 101 matching lines @@
 }
 
 void ComponentLoader::AddScriptBubble() {
   if (FeatureSwitch::script_bubble()->IsEnabled()) {
     script_bubble_id_ =
         Add(IDR_SCRIPT_BUBBLE_MANIFEST,
             FilePath(FILE_PATH_LITERAL("script_bubble")));
   }
 }
 
+// static
+void ComponentLoader::EnableBackgroundExtensionsForTesting() {
+  enable_background_extenstions_during_testing = true;
+}
+
 void ComponentLoader::AddDefaultComponentExtensions() {
+  // Do not add component extensions that have background pages here -- add them
+  // to AddDefaultComponentExtensionsWithBackgroundPages.
+
 #if defined(OS_CHROMEOS)
-  if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kGuestSession))
+  const CommandLine* command_line = CommandLine::ForCurrentProcess();
+  if (!command_line->HasSwitch(switches::kGuestSession))
     Add(IDR_BOOKMARKS_MANIFEST,
         FilePath(FILE_PATH_LITERAL("bookmark_manager")));
 #else
   Add(IDR_BOOKMARKS_MANIFEST, FilePath(FILE_PATH_LITERAL("bookmark_manager")));
 #endif
 
 #if defined(OS_CHROMEOS)
-  Add(IDR_WALLPAPERMANAGER_MANIFEST,
-      FilePath(FILE_PATH_LITERAL("chromeos/wallpaper_manager")));
-#endif
-
-#if defined(FILE_MANAGER_EXTENSION)
-  AddFileManagerExtension();
-#endif
-
-#if defined(OS_CHROMEOS)
-  const CommandLine* command_line = CommandLine::ForCurrentProcess();
-  if (command_line->HasSwitch(switches::kEnableBackgroundLoader)) {
-    Add(IDR_BACKLOADER_MANIFEST,
-        FilePath(FILE_PATH_LITERAL("backloader")));
-  }
-
   Add(IDR_MOBILE_MANIFEST,
       FilePath(FILE_PATH_LITERAL("/usr/share/chromeos-assets/mobile")));
 
   Add(IDR_CROSH_BUILTIN_MANIFEST, FilePath(FILE_PATH_LITERAL(
       "/usr/share/chromeos-assets/crosh_builtin")));
 
   AddGaiaAuthExtension();
 
   // TODO(gauravsh): Only include echo extension on official builds.
   FilePath echo_extension_path(FILE_PATH_LITERAL(
       "/usr/share/chromeos-assets/echo"));
   if (command_line->HasSwitch(switches::kEchoExtensionPath)) {
     echo_extension_path =
         command_line->GetSwitchValuePath(switches::kEchoExtensionPath);
   }
   Add(IDR_ECHO_MANIFEST, echo_extension_path);
 
 #if defined(OFFICIAL_BUILD)
   if (browser_defaults::enable_help_app) {
     Add(IDR_HELP_MANIFEST,
         FilePath(FILE_PATH_LITERAL("/usr/share/chromeos-assets/helpapp")));
   }
 #endif
 #endif  // !defined(OS_CHROMEOS)
 
   Add(IDR_WEBSTORE_MANIFEST, FilePath(FILE_PATH_LITERAL("web_store")));
 
-#if defined(ENABLE_SETTINGS_APP)
-  Add(IDR_SETTINGS_APP_MANIFEST, FilePath(FILE_PATH_LITERAL("settings_app")));
-#endif
-
 #if !defined(OS_CHROMEOS)
   // Cloud Print component app. Not required on Chrome OS.
   Add(IDR_CLOUDPRINT_MANIFEST, FilePath(FILE_PATH_LITERAL("cloud_print")));
 #endif
 
-#if defined(OS_CHROMEOS)
-  // Register access extensions only if accessibility is enabled.
-  if (local_state_->GetBoolean(prefs::kSpokenFeedbackEnabled)) {
-    FilePath path = FilePath(extension_misc::kAccessExtensionPath)
-        .AppendASCII(extension_misc::kChromeVoxDirectoryName);
-    Add(IDR_CHROMEVOX_MANIFEST, path);
-  }
-#endif
-
   // If a URL for the enterprise webstore has been specified, load the
   // component extension. This extension might also be loaded later, because
   // it is specified by policy, and on ChromeOS policies are loaded after
   // the browser process has started.
   AddOrReloadEnterpriseWebStore();
 
 #if defined(USE_ASH)
   AddChromeApp();
 #endif
 
   AddScriptBubble();
+  AddDefaultComponentExtensionsWithBackgroundPages();
+}
+
+void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages() {
+  const CommandLine* command_line = CommandLine::ForCurrentProcess();
+
+  // Component extensions with background pages are not enabled during tests
+  // because they generate a lot of background behavior that can interfere.
+  if (!enable_background_extenstions_during_testing &&

[Yoyo Zhou, 2012/11/27 23:54:18]

typo: extensions

[tapted, 2012/11/28 06:21:14]

Drat. Done.

+      command_line->HasSwitch(switches::kTestType)) {
+    return;
+  }
+
+  AddFileManagerExtension();
+
+#if defined(OS_CHROMEOS)
+  Add(IDR_WALLPAPERMANAGER_MANIFEST,
+      FilePath(FILE_PATH_LITERAL("chromeos/wallpaper_manager")));
+
+  if (command_line->HasSwitch(switches::kEnableBackgroundLoader)) {
+    Add(IDR_BACKLOADER_MANIFEST,
+        FilePath(FILE_PATH_LITERAL("backloader")));
+  }
+
+  // Register access extensions only if accessibility is enabled.
+  if (local_state_->GetBoolean(prefs::kSpokenFeedbackEnabled)) {
+    FilePath path = FilePath(extension_misc::kAccessExtensionPath)
+        .AppendASCII(extension_misc::kChromeVoxDirectoryName);
+    Add(IDR_CHROMEVOX_MANIFEST, path);
+  }
+#endif
+
+#if defined(ENABLE_SETTINGS_APP)
+  Add(IDR_SETTINGS_APP_MANIFEST, FilePath(FILE_PATH_LITERAL("settings_app")));
+#endif
 }
 
 // static
 void ComponentLoader::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterStringPref(prefs::kEnterpriseWebStoreURL,
                             std::string() /* default_value */,
                             PrefService::UNSYNCABLE_PREF);
   prefs->RegisterStringPref(prefs::kEnterpriseWebStoreName,
                             std::string() /* default_value */,
                             PrefService::UNSYNCABLE_PREF);
 }
 
 }  // namespace extensions