Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/tests/pub/pubspec_test.dart

Issue 11275054: Modified unittest to use new argument syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/isolate/timer_cancel_test.dart ('K') | « tests/isolate/timer_test.dart ('k') | utils/tests/pub/version_test.dart » ('j') | utils/tests/pub/version_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/pubspec_test.dart
===================================================================
--- utils/tests/pub/pubspec_test.dart (revision 14114)
+++ utils/tests/pub/pubspec_test.dart (working copy)
@@ -36,9 +36,9 @@
var foo = pubspec.dependencies[0];
expect(foo.name, equals('foo'));
- expect(foo.constraint.allows(new Version(1, 2, 3)));
- expect(foo.constraint.allows(new Version(1, 2, 5)));
- expect(!foo.constraint.allows(new Version(3, 4, 5)));
+ expect(foo.constraint.allows(new Version(1, 2, 3)), isTrue);
+ expect(foo.constraint.allows(new Version(1, 2, 5)), isTrue);
+ expect(!foo.constraint.allows(new Version(3, 4, 5)), isTrue);
nweiz 2012/10/26 18:36:33 Can we get rid of the "!" and use isFalse?
gram 2012/10/26 22:26:27 Done.
});
test("throws if the description isn't valid", () {
« tests/isolate/timer_cancel_test.dart ('K') | « tests/isolate/timer_test.dart ('k') | utils/tests/pub/version_test.dart » ('j') | utils/tests/pub/version_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698