Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: tests/html/window_open_test.dart

Issue 11275054: Modified unittest to use new argument syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/html/window_open_test.dart
===================================================================
--- tests/html/window_open_test.dart (revision 14114)
+++ tests/html/window_open_test.dart (working copy)
@@ -10,7 +10,7 @@
scriptTag.innerHTML = code;
document.body.nodes.add(scriptTag);
}
- evaluateJavaScript('(testRunner || layoutTestController).setCanOpenWindows()');
+// evaluateJavaScript('(window.testRunner || window.layoutTestController) ? (window.testRunner || window.layoutTestController).setCanOpenWindows() : null');
Siggi Cherem (dart-lang) 2012/10/26 00:44:51 strange - uncomment?
gram 2012/10/26 00:50:34 Good catch - this file should not be in the CL. It
test('TwoArgumentVersion', () {
Window win = window.open('../resources/pong.html', 'testWindow');

Powered by Google App Engine
This is Rietveld 408576698