Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: pkg/unittest/mock.dart

Issue 11275054: Modified unittest to use new argument syntax. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * The error formatter for mocking is a bit different from the default one 6 * The error formatter for mocking is a bit different from the default one
7 * for unit testing; instead of the third argument being a 'reason' 7 * for unit testing; instead of the third argument being a 'reason'
8 * it is instead a [signature] describing the method signature filter 8 * it is instead a [signature] describing the method signature filter
9 * that was used to select the logs that were verified. 9 * that was used to select the logs that were verified.
10 */ 10 */
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 } 425 }
426 return rtn; 426 return rtn;
427 } 427 }
428 428
429 /** Apply a unit test [Matcher] to the [LogEntryList]. */ 429 /** Apply a unit test [Matcher] to the [LogEntryList]. */
430 LogEntryList verify(Matcher matcher) { 430 LogEntryList verify(Matcher matcher) {
431 if (_mockFailureHandler == null) { 431 if (_mockFailureHandler == null) {
432 _mockFailureHandler = 432 _mockFailureHandler =
433 new _MockFailureHandler(getOrCreateExpectFailureHandler()); 433 new _MockFailureHandler(getOrCreateExpectFailureHandler());
434 } 434 }
435 expect(logs, matcher, filter, _mockFailureHandler); 435 expect(logs, matcher, reason:filter, failureHandler: _mockFailureHandler);
Jennifer Messerly 2012/10/26 02:57:05 I think this would read better if it was called "f
gram 2012/10/26 22:26:27 It's a class, not a method, so it should be a noun
Jennifer Messerly 2012/10/26 22:50:16 Makes sense. I was assuming it was a callback :)
436 return this; 436 return this;
437 } 437 }
438 438
439 /** 439 /**
440 * Iterate through the list and call the [validator] function with the 440 * Iterate through the list and call the [validator] function with the
441 * log [List] and position. The [validator] should return the number of 441 * log [List] and position. The [validator] should return the number of
442 * positions to advance upon success, or zero upon failure. When zero is 442 * positions to advance upon success, or zero upon failure. When zero is
443 * returned an error is reported. [reason] can be used to provide a 443 * returned an error is reported. [reason] can be used to provide a
444 * more descriptive failure message. If a failure occurred false will be 444 * more descriptive failure message. If a failure occurred false will be
445 * returned (unless the failure handler itself threw an exception); 445 * returned (unless the failure handler itself threw an exception);
(...skipping 1004 matching lines...) Expand 10 before | Expand all | Expand 10 after
1450 } 1450 }
1451 } 1451 }
1452 } 1452 }
1453 1453
1454 /** Clear both logs and behavior. */ 1454 /** Clear both logs and behavior. */
1455 void reset() { 1455 void reset() {
1456 resetBehavior(); 1456 resetBehavior();
1457 clearLogs(); 1457 clearLogs();
1458 } 1458 }
1459 } 1459 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698