Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11275042: Renaming IndexOutOfRangeException to RangeError. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Renaming IndexOutOfRangeException to RangeError. It now extends ArgumentError. Committed: https://code.google.com/p/dart/source/detail?r=14405

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : ADded RangeError.value constructor. Made VM calls work. #

Total comments: 6

Patch Set 4 : Regenerated html files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -440 lines) Patch
M lib/collection/arrays.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 2 8 chunks +14 lines, -14 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/lib/string_helper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lib/core/errors.dart View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M lib/core/exceptions.dart View 1 1 chunk +0 lines, -12 lines 0 comments Download
M lib/core/expect.dart View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M lib/core/list.dart View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M lib/html/src/_Lists.dart View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M lib/io/file_impl.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M lib/scalarlist/byte_arrays.dart View 20 chunks +20 lines, -20 lines 0 comments Download
M lib/utf/utf_core.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/unittest/core_matchers.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/array.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/byte_array.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
runtime/lib/byte_array.dart View 1 2 21 chunks +23 lines, -23 lines 0 comments Download
M runtime/lib/growable_array.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/regexp_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/string_base.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/tests/vm/dart/byte_array_test.dart View 31 chunks +170 lines, -170 lines 0 comments Download
M runtime/vm/exceptions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 2 chunks +20 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 chunks +24 lines, -4 lines 0 comments Download
M tests/compiler/dart2js_extra/constant_javascript_semantics2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/constant_javascript_semantics3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/index_out_of_range_exception_test.dart View 1 1 chunk +0 lines, -74 lines 0 comments Download
M tests/corelib/list_get_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/list_insert_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/list_remove_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/list_removeat_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/corelib/list_set_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/corelib/range_error_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/corelib/string_base_vm_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/string_substring_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/corelib/string_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/list_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/language/value_range2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/value_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/byte_array_test.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lasse Reichstein Nielsen
Test expectations for dart2js/dart2dart will be added when they have been tested.
8 years, 1 month ago (2012-10-25 14:26:45 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/11275042/diff/1/lib/core/errors.dart File lib/core/errors.dart (right): https://codereview.chromium.org/11275042/diff/1/lib/core/errors.dart#newcode48 lib/core/errors.dart:48: RangeError(int value) : super("Value of of range: $value"); ...
8 years, 1 month ago (2012-10-25 14:31:37 UTC) #2
Ivan Posva
Please include somebody from the VM team when changing runtime files. This change is missing ...
8 years, 1 month ago (2012-10-26 02:28:12 UTC) #3
Lasse Reichstein Nielsen
Good catch Ivan. Please check that I fixed the VM too. https://codereview.chromium.org/11275042/diff/1/lib/core/errors.dart File lib/core/errors.dart (right): ...
8 years, 1 month ago (2012-10-26 11:30:21 UTC) #4
Lasse Reichstein Nielsen
Please take another look.
8 years, 1 month ago (2012-11-01 10:04:28 UTC) #5
floitsch
LGTM. https://codereview.chromium.org/11275042/diff/9001/lib/core/expect.dart File lib/core/expect.dart (right): https://codereview.chromium.org/11275042/diff/9001/lib/core/expect.dart#newcode270 lib/core/expect.dart:270: String msg = reason == null ? "" ...
8 years, 1 month ago (2012-11-01 12:11:39 UTC) #6
Florian Schneider
lgtm runtime/vm/
8 years, 1 month ago (2012-11-01 12:48:33 UTC) #7
Lasse Reichstein Nielsen
8 years, 1 month ago (2012-11-01 13:39:09 UTC) #8 
https://codereview.chromium.org/11275042/diff/9001/lib/core/expect.dart
File lib/core/expect.dart (right):

https://codereview.chromium.org/11275042/diff/9001/lib/core/expect.dart#newco...
lib/core/expect.dart:270: String msg = reason == null ? "" : reason;
I believe I have seen places where one check is nested in another, and it passes
on the reason. That means that omitting the reason for the outer check will
explicitly pass null to the inner check.

https://codereview.chromium.org/11275042/diff/9001/lib/html/dart2js/html_dart...
File lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11275042/diff/9001/lib/html/dart2js/html_dart...
lib/html/dart2js/html_dart2js.dart:40865: +   * Throws an [RangeError] if
[start] or
Will do, or see if I forgot the template too.

https://codereview.chromium.org/11275042/diff/9001/lib/html/dartium/html_dart...
File lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/11275042/diff/9001/lib/html/dartium/html_dart...
lib/html/dartium/html_dartium.dart:44210: +   * Throws an [RangeError] if
[start] or
Fixing.

Powered by Google App Engine
This is Rietveld 408576698