Clean up test.dart framework.

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart	(revision 14052)
+++ tools/testing/dart/test_runner.dart	(working copy)
@@ -77,6 +77,7 @@
   String displayName;
   TestOutput output;
   bool isNegative;
+  bool usesWebDriver;

[Mads Ager (google), 2012/10/25 08:11:55]

I'm not sure what we gain by having this as a member instead of the getter. It
seems to be a lot more code for the same functionality?

[Emily Fortuna, 2012/10/25 18:21:20]

I agree. The reason I changed this is I was finding I was having to add "ie10"
in an awful lot of extra places sprinkled throughout our test framework, so this
was an attempt to avoid that. But perhaps the extra spots are worth having less
code.?

[Mads Ager (google), 2012/10/25 18:47:44]

I strongly agree with your use of TestUtils.usesWebDriver as the one place to
have the list of browser runtimes!

What I was wondering is if it would be better to just keep the getter on line
167 of the 'before' part of this change list and not introduce the argument to
the constructor and the field. It seems to me that the getter will give the
correct result and that the amount of places where we have the string 'ie9' will
be the same (no changed line in this CL contains browser names as strings)? That
would reduce this patch set to only the change to fix the use of 'browserUsed'.
I'm fine either way so I'll leave it to your judgement.

   Set<String> expectedOutcomes;
   TestCaseEvent completedHandler;
   TestInformation info;
@@ -87,7 +88,8 @@
            this.completedHandler,
            this.expectedOutcomes,
            {this.isNegative: false,
-            this.info: null}) {
+            this.info: null,
+            this.usesWebDriver: false}) {
     if (!isNegative) {
       this.isNegative = displayName.contains("negative_test");
     }
@@ -164,8 +166,6 @@
   List<String> get batchRunnerArguments => ['-batch'];
   List<String> get batchTestArguments => commands.last().arguments;
 
-  bool get usesWebDriver => TestUtils.usesWebDriver(configuration['runtime']);
-
   void completed() { completedHandler(this); }
 }
 
@@ -183,9 +183,10 @@
   int numRetries;
 
   BrowserTestCase(displayName, commands, configuration, completedHandler,
-      expectedOutcomes, info, isNegative)
+      expectedOutcomes, info, isNegative, {useWebDriver: false})
     : super(displayName, commands, configuration, completedHandler,
-        expectedOutcomes, isNegative: isNegative, info: info) {
+        expectedOutcomes, isNegative: isNegative, info: info,
+        usesWebDriver: useWebDriver) {
     numRetries = 2; // Allow two retries to compensate for flaky browser tests.
   }
 
@@ -1141,7 +1142,7 @@
 
   void _runTest(TestCase test) {
     if (test.usesWebDriver) {
-      browserUsed = test.configuration['browser'];
+      browserUsed = test.configuration['runtime'];

[Mads Ager (google), 2012/10/25 08:11:55]

Thank you! I hope this will work out on the bots.

       if (_needsSelenium) _ensureSeleniumServerRunning();
     }
     _progress.testAdded();