Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 11275019: Include an explicit author when committing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 69f257060c08c44f240698b3d9b0320266f28acd..6b464097bf8060229758efe2f770a59d02d713ef 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -999,7 +999,8 @@ class GitRepoDescriptor extends DirectoryDescriptor {
workingDir = rootDir;
return runGit(['init']);
}).chain((_) => runGit(['add', '.']))
- .chain((_) => runGit(['commit', '-m', 'initial commit']))
+ .chain((_) => runGit(['commit', '-m', 'initial commit',
+ '--author="Pub Test <pub@dartlang.org>"']))
.transform((_) => workingDir);
}
@@ -1013,7 +1014,8 @@ class GitRepoDescriptor extends DirectoryDescriptor {
return super.create(parentDir).chain((rootDir) {
workingDir = rootDir;
return runGit(['add', '.']);
- }).chain((_) => runGit(['commit', '-m', 'update']));
+ }).chain((_) => runGit(['commit', '-m', 'update',
+ '--author="Pub Test <pub@dartlang.org>"']));
}
/**
@@ -1050,7 +1052,11 @@ class GitRepoDescriptor extends DirectoryDescriptor {
Future<String> _runGit(List<String> args, Directory workingDir) {
return runGit(args, workingDir: workingDir.path).transform((result) {
- if (!result.success) throw "Error running git: ${result.stderr}";
+ if (!result.success) {
+ throw "Error running: git ${Strings.join(args, ' ')}\n"
+ "${Strings.join(result.stderr, '\n')}";
+ }
+
return result.stdout;
});
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698