Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 1127453003: VM: Don't emit usage counter and range feedback code and when optimizations are disabled. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_mips.cc
===================================================================
--- runtime/vm/stub_code_mips.cc (revision 45494)
+++ runtime/vm/stub_code_mips.cc (working copy)
@@ -25,6 +25,7 @@
DEFINE_FLAG(bool, use_slow_path, false,
"Set to true for debugging & verifying the slow paths.");
DECLARE_FLAG(bool, trace_optimized_ic_calls);
+DECLARE_FLAG(int, optimization_counter_threshold);
// Input parameters:
// RA : return address.
@@ -1337,15 +1338,17 @@
// Loads function into 'temp_reg'.
void StubCode::GenerateUsageCounterIncrement(Assembler* assembler,
Register temp_reg) {
- __ Comment("UsageCounterIncrement");
- Register ic_reg = S5;
- Register func_reg = temp_reg;
- ASSERT(temp_reg == T0);
- __ Comment("Increment function counter");
- __ lw(func_reg, FieldAddress(ic_reg, ICData::owner_offset()));
- __ lw(T1, FieldAddress(func_reg, Function::usage_counter_offset()));
- __ addiu(T1, T1, Immediate(1));
- __ sw(T1, FieldAddress(func_reg, Function::usage_counter_offset()));
+ if (FLAG_optimization_counter_threshold >= 0) {
+ __ Comment("UsageCounterIncrement");
+ Register ic_reg = S5;
+ Register func_reg = temp_reg;
+ ASSERT(temp_reg == T0);
+ __ Comment("Increment function counter");
+ __ lw(func_reg, FieldAddress(ic_reg, ICData::owner_offset()));
+ __ lw(T1, FieldAddress(func_reg, Function::usage_counter_offset()));
+ __ addiu(T1, T1, Immediate(1));
+ __ sw(T1, FieldAddress(func_reg, Function::usage_counter_offset()));
+ }
}
@@ -1404,14 +1407,16 @@
__ Stop("Incorrect IC data");
__ Bind(&ok);
#endif
- // Update counter.
- const intptr_t count_offset = ICData::CountIndexFor(num_args) * kWordSize;
- __ lw(T4, Address(T0, count_offset));
- __ AddImmediateDetectOverflow(T7, T4, Smi::RawValue(1), T5, T6);
- __ slt(CMPRES1, T5, ZR); // T5 is < 0 if there was overflow.
- __ LoadImmediate(T4, Smi::RawValue(Smi::kMaxValue));
- __ movz(T4, T7, CMPRES1);
- __ sw(T4, Address(T0, count_offset));
+ if (FLAG_optimization_counter_threshold >= 0) {
+ // Update counter.
+ const intptr_t count_offset = ICData::CountIndexFor(num_args) * kWordSize;
+ __ lw(T4, Address(T0, count_offset));
+ __ AddImmediateDetectOverflow(T7, T4, Smi::RawValue(1), T5, T6);
+ __ slt(CMPRES1, T5, ZR); // T5 is < 0 if there was overflow.
+ __ LoadImmediate(T4, Smi::RawValue(Smi::kMaxValue));
+ __ movz(T4, T7, CMPRES1);
+ __ sw(T4, Address(T0, count_offset));
+ }
__ Ret();
}
@@ -1593,13 +1598,15 @@
const intptr_t count_offset = ICData::CountIndexFor(num_args) * kWordSize;
__ lw(T3, Address(T0, target_offset));
- // Update counter.
- __ lw(T4, Address(T0, count_offset));
- __ AddImmediateDetectOverflow(T7, T4, Smi::RawValue(1), T5, T6);
- __ slt(CMPRES1, T5, ZR); // T5 is < 0 if there was overflow.
- __ LoadImmediate(T4, Smi::RawValue(Smi::kMaxValue));
- __ movz(T4, T7, CMPRES1);
- __ sw(T4, Address(T0, count_offset));
+ if (FLAG_optimization_counter_threshold >= 0) {
+ // Update counter.
+ __ lw(T4, Address(T0, count_offset));
+ __ AddImmediateDetectOverflow(T7, T4, Smi::RawValue(1), T5, T6);
+ __ slt(CMPRES1, T5, ZR); // T5 is < 0 if there was overflow.
+ __ LoadImmediate(T4, Smi::RawValue(Smi::kMaxValue));
+ __ movz(T4, T7, CMPRES1);
+ __ sw(T4, Address(T0, count_offset));
+ }
__ Comment("Call target");
__ Bind(&call_target_function);
@@ -1789,13 +1796,15 @@
const intptr_t target_offset = ICData::TargetIndexFor(0) * kWordSize;
const intptr_t count_offset = ICData::CountIndexFor(0) * kWordSize;
- // Increment count for this call.
- __ lw(T4, Address(T0, count_offset));
- __ AddImmediateDetectOverflow(T7, T4, Smi::RawValue(1), T5, T6);
- __ slt(CMPRES1, T5, ZR); // T5 is < 0 if there was overflow.
- __ LoadImmediate(T4, Smi::RawValue(Smi::kMaxValue));
- __ movz(T4, T7, CMPRES1);
- __ sw(T4, Address(T0, count_offset));
+ if (FLAG_optimization_counter_threshold >= 0) {
+ // Increment count for this call.
+ __ lw(T4, Address(T0, count_offset));
+ __ AddImmediateDetectOverflow(T7, T4, Smi::RawValue(1), T5, T6);
+ __ slt(CMPRES1, T5, ZR); // T5 is < 0 if there was overflow.
+ __ LoadImmediate(T4, Smi::RawValue(Smi::kMaxValue));
+ __ movz(T4, T7, CMPRES1);
+ __ sw(T4, Address(T0, count_offset));
+ }
// Load arguments descriptor into S4.
__ lw(S4, FieldAddress(S5, ICData::arguments_descriptor_offset()));
« no previous file with comments | « runtime/vm/stub_code_ia32.cc ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698