Adding --enable-stats-table on desktop multipage_benchmarks to prevent crash (NOT FOR REVIEW)

Adding --enable-stats-table on desktop multipage_benchmarks to prevent crash
caused by --enable-benchmarking.

BUG=157866
I believe this has been taken over: http://code.google.com/p/chromium/issues/detail?id=168640

[hartmanng, 2012-10-25 14:16:13]

Please take a look.

[hartmanng, 2012-10-25 15:10:09]

Sorry for the spam, but it looks like this is not yet ready for review. After
further tests, I found out the following:

-on a debug build, passing in --enable-benchmarking without passing in
--enable-stats-table will crash at chrome_content_browser_client.cc(992) on a
DCHECK. If the comment there is accurate, it seems like we really should be
specifying --enable-stats-table anytime we pass in --enable-benchmarking.
-on a debug build, passing in both --enable-benchmarking and
--enable-stats-table seems to work fine.
-HOWEVER, on a release build, passing in --enable-stats-table (with or without
--enable-benchmarking) causes a segfault on startup. I'm looking into this now.

[tonyg, 2012-10-25 17:43:07]

Thanks for investigating. That crash is also tracked by http://crbug.com/137243

On Thu, Oct 25, 2012 at 8:10 AM,  <hartmanng@chromium.org> wrote:
> Sorry for the spam, but it looks like this is not yet ready for review.
> After
> further tests, I found out the following:
>
> -on a debug build, passing in --enable-benchmarking without passing in
> --enable-stats-table will crash at chrome_content_browser_client.cc(992) on
> a
> DCHECK. If the comment there is accurate, it seems like we really should be
> specifying --enable-stats-table anytime we pass in --enable-benchmarking.
> -on a debug build, passing in both --enable-benchmarking and
> --enable-stats-table seems to work fine.
> -HOWEVER, on a release build, passing in --enable-stats-table (with or
> without
> --enable-benchmarking) causes a segfault on startup. I'm looking into this
> now.
>
> https://codereview.chromium.org/11274046/

[tonyg, 2012-10-25 21:47:29]

Brandon mentioned he ran into this this morning.

[hartmanng, 2012-10-26 15:51:26]

Just sent http://codereview.chromium.org/11260033/ in for review, which should
fix crbug.com/137243 (the --enable-stats-table crash). As soon as it lands, I
should be able to get this one going to fix the benchmarking on Debug builds.

[tonyg, 2012-10-26 19:02:21]

One potential wrinkle is that the scrolling test on the bots runs
against ToT and against the reference build, which is a static build
checked in several months ago. If we just start passing
--enable-stats-table, then AIUI we'd break the test as the ref build
would crash. Is there anything we can do short of updating the ref
builds. Like maybe only pass --enable-stats-table for debug builds or
remove the DCHECK() that tests that --enable-stats-table is always
used with --enable-benchmarking?

On Fri, Oct 26, 2012 at 8:51 AM,  <hartmanng@chromium.org> wrote:
> Just sent http://codereview.chromium.org/11260033/ in for review, which
> should
> fix crbug.com/137243 (the --enable-stats-table crash). As soon as it lands,
> I
> should be able to get this one going to fix the benchmarking on Debug
> builds.
>
> https://codereview.chromium.org/11274046/