Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 11274046: Adding --enable-stats-table on desktop multipage_benchmarks to prevent crash (NOT FOR REVIEW) (Closed)

Created:
8 years, 1 month ago by hartmanng
Modified:
7 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, pam+watch_chromium.org, bajones
Visibility:
Public.

Description

Adding --enable-stats-table on desktop multipage_benchmarks to prevent crash caused by --enable-benchmarking. BUG=157866 I believe this has been taken over: http://code.google.com/p/chromium/issues/detail?id=168640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hartmanng
Please take a look.
8 years, 1 month ago (2012-10-25 14:16:13 UTC) #1
hartmanng
Sorry for the spam, but it looks like this is not yet ready for review. ...
8 years, 1 month ago (2012-10-25 15:10:09 UTC) #2
tonyg
Thanks for investigating. That crash is also tracked by http://crbug.com/137243 On Thu, Oct 25, 2012 ...
8 years, 1 month ago (2012-10-25 17:43:07 UTC) #3
tonyg
Brandon mentioned he ran into this this morning.
8 years, 1 month ago (2012-10-25 21:47:29 UTC) #4
hartmanng
Just sent http://codereview.chromium.org/11260033/ in for review, which should fix crbug.com/137243 (the --enable-stats-table crash). As soon ...
8 years, 1 month ago (2012-10-26 15:51:26 UTC) #5
tonyg
8 years, 1 month ago (2012-10-26 19:02:21 UTC) #6
One potential wrinkle is that the scrolling test on the bots runs
against ToT and against the reference build, which is a static build
checked in several months ago. If we just start passing
--enable-stats-table, then AIUI we'd break the test as the ref build
would crash. Is there anything we can do short of updating the ref
builds. Like maybe only pass --enable-stats-table for debug builds or
remove the DCHECK() that tests that --enable-stats-table is always
used with --enable-benchmarking?

On Fri, Oct 26, 2012 at 8:51 AM,  <hartmanng@chromium.org> wrote:
> Just sent http://codereview.chromium.org/11260033/ in for review, which
> should
> fix crbug.com/137243 (the --enable-stats-table crash). As soon as it lands,
> I
> should be able to get this one going to fix the benchmarking on Debug
> builds.
>
> https://codereview.chromium.org/11274046/

Powered by Google App Engine
This is Rietveld 408576698