runtime/lib/collection_sources.gypi - Issue 11274043: Move Arrays, Collections and Maps into a new library, dart:collections.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/collection_sources.gypi

Issue 11274043: Move Arrays, Collections and Maps into a new library, dart:collections. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rename collections->collection. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
	Ivan Posva 2012/10/26 04:48:17 This file should reside next to the actual sources This file should reside next to the actual sources in lib/collection. There is nothing runtime specific here. Mads Ager (google) 2012/10/26 06:05:54 I think it would be fine to move this to lib/colle Show quoted text On 2012/10/26 04:48:17, Ivan Posva wrote: > This file should reside next to the actual sources in lib/collection. There is > nothing runtime specific here. I think it would be fine to move this to lib/collection. Most of this should go away and be replaced by the one main library file which the VM should be able to load. Any progress on issue 5099? Anders Johnsen 2012/10/26 09:23:15 Done. Show quoted text On 2012/10/26 06:05:54, Mads Ager wrote: > On 2012/10/26 04:48:17, Ivan Posva wrote: > > This file should reside next to the actual sources in lib/collection. There is > > nothing runtime specific here. > > I think it would be fine to move this to lib/collection. Most of this should go > away and be replaced by the one main library file which the VM should be able to > load. Any progress on issue 5099? Done. Anders Johnsen 2012/10/26 09:23:15 Done. Show quoted text On 2012/10/26 04:48:17, Ivan Posva wrote: > This file should reside next to the actual sources in lib/collection. There is > nothing runtime specific here. Done.
2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 # Sources visible via dart:scalarlist library.	5 # This file contains all sources for the dart:collection library.

6

7 {	6 {

8 'sources': [	7 'sources': [

9 'byte_array.cc',	8 '../../lib/collection/arrays.dart',

10 'byte_array.dart',	9 '../../lib/collection/collections.dart',

	10 '../../lib/collection/maps.dart',

11 ],	11 ],

12 }	12 }

13	13

OLD	NEW

« lib/collection/arrays.dart ('K') | « lib/coreimpl/maps.dart ('k') | runtime/vm/bootstrap.h » ('j') | runtime/vm/bootstrap.cc » ('J')