Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/sync/test/integration/migration_test.cc

Issue 1127403005: Sync: disable 2 flaky migration tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/compiler_specific.h" 5 #include "base/compiler_specific.h"
6 #include "base/memory/scoped_vector.h" 6 #include "base/memory/scoped_vector.h"
7 #include "base/prefs/scoped_user_pref_update.h" 7 #include "base/prefs/scoped_user_pref_update.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/sync/profile_sync_service.h" 9 #include "chrome/browser/sync/profile_sync_service.h"
10 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 10 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 TRIGGER_NOTIFICATION); 280 TRIGGER_NOTIFICATION);
281 } 281 }
282 282
283 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriBoth) { 283 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriBoth) {
284 RunSingleClientMigrationTest( 284 RunSingleClientMigrationTest(
285 MakeList(MakeSet(syncer::PREFERENCES, syncer::NIGORI)), 285 MakeList(MakeSet(syncer::PREFERENCES, syncer::NIGORI)),
286 MODIFY_PREF); 286 MODIFY_PREF);
287 } 287 }
288 288
289 // The whole shebang -- all data types. 289 // The whole shebang -- all data types.
290 #if defined(OS_WIN) || defined(OS_MACOSX)
291 // http://crbug.com/403778 290 // http://crbug.com/403778
292 #define MAYBE_AllTypesIndividually DISABLED_AllTypesIndividually 291 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
293 #else 292 DISABLED_AllTypesIndividually) {
294 #define MAYBE_AllTypesIndividually AllTypesIndividually
295 #endif
296 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, MAYBE_AllTypesIndividually) {
297 ASSERT_TRUE(SetupClients()); 293 ASSERT_TRUE(SetupClients());
298 RunSingleClientMigrationTest(GetPreferredDataTypesList(), MODIFY_BOOKMARK); 294 RunSingleClientMigrationTest(GetPreferredDataTypesList(), MODIFY_BOOKMARK);
299 } 295 }
300 296
301 #if defined(OS_WIN) || defined(OS_MACOSX)
302 // http://crbug.com/403778 297 // http://crbug.com/403778
303 #define MAYBE_AllTypesIndividuallyTriggerNotification \
304 DISABLED_AllTypesIndividuallyTriggerNotification
305 #else
306 #define MAYBE_AllTypesIndividuallyTriggerNotification \
307 AllTypesIndividuallyTriggerNotification
308 #endif
309 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, 298 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
310 MAYBE_AllTypesIndividuallyTriggerNotification) { 299 DISABLED_AllTypesIndividuallyTriggerNotification) {
311 ASSERT_TRUE(SetupClients()); 300 ASSERT_TRUE(SetupClients());
312 RunSingleClientMigrationTest(GetPreferredDataTypesList(), 301 RunSingleClientMigrationTest(GetPreferredDataTypesList(),
313 TRIGGER_NOTIFICATION); 302 TRIGGER_NOTIFICATION);
314 } 303 }
315 304
316 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesAtOnce) { 305 IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesAtOnce) {
317 ASSERT_TRUE(SetupClients()); 306 ASSERT_TRUE(SetupClients());
318 RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()), 307 RunSingleClientMigrationTest(MakeList(GetPreferredDataTypes()),
319 MODIFY_PREF); 308 MODIFY_PREF);
320 } 309 }
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 // Do not add optional datatypes. 421 // Do not add optional datatypes.
433 } 422 }
434 423
435 ~MigrationReconfigureTest() override {} 424 ~MigrationReconfigureTest() override {}
436 425
437 private: 426 private:
438 DISALLOW_COPY_AND_ASSIGN(MigrationReconfigureTest); 427 DISALLOW_COPY_AND_ASSIGN(MigrationReconfigureTest);
439 }; 428 };
440 429
441 } // namespace 430 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698