Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: src/objects-inl.h

Issue 11274014: Store Object.observe state per-isolate rather than per-context (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use ObjectHashTable directly Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 bool Object::IsPolymorphicCodeCacheHashTable() { 719 bool Object::IsPolymorphicCodeCacheHashTable() {
720 return IsHashTable(); 720 return IsHashTable();
721 } 721 }
722 722
723 723
724 bool Object::IsMapCache() { 724 bool Object::IsMapCache() {
725 return IsHashTable(); 725 return IsHashTable();
726 } 726 }
727 727
728 728
729 bool Object::IsObjectHashTable() {
730 // TODO: Is this sufficient?
rossberg 2012/11/06 12:27:09 Yeah, I don't think it's worth introducing the ext
adamk 2012/11/06 12:59:13 Okay, I've removed this and completely redone the
731 return IsHashTable();
732 }
733
734
729 bool Object::IsPrimitive() { 735 bool Object::IsPrimitive() {
730 return IsOddball() || IsNumber() || IsString(); 736 return IsOddball() || IsNumber() || IsString();
731 } 737 }
732 738
733 739
734 bool Object::IsJSGlobalProxy() { 740 bool Object::IsJSGlobalProxy() {
735 bool result = IsHeapObject() && 741 bool result = IsHeapObject() &&
736 (HeapObject::cast(this)->map()->instance_type() == 742 (HeapObject::cast(this)->map()->instance_type() ==
737 JS_GLOBAL_PROXY_TYPE); 743 JS_GLOBAL_PROXY_TYPE);
738 ASSERT(!result || IsAccessCheckNeeded()); 744 ASSERT(!result || IsAccessCheckNeeded());
(...skipping 4810 matching lines...) Expand 10 before | Expand all | Expand 10 after
5549 #undef WRITE_UINT32_FIELD 5555 #undef WRITE_UINT32_FIELD
5550 #undef READ_SHORT_FIELD 5556 #undef READ_SHORT_FIELD
5551 #undef WRITE_SHORT_FIELD 5557 #undef WRITE_SHORT_FIELD
5552 #undef READ_BYTE_FIELD 5558 #undef READ_BYTE_FIELD
5553 #undef WRITE_BYTE_FIELD 5559 #undef WRITE_BYTE_FIELD
5554 5560
5555 5561
5556 } } // namespace v8::internal 5562 } } // namespace v8::internal
5557 5563
5558 #endif // V8_OBJECTS_INL_H_ 5564 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698