Issue 11274007: Move StringBufferImpl from coreimpl to core as _StringBufferImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11274007: Move StringBufferImpl from coreimpl to core as _StringBufferImpl. (Closed)

Created:
8 years, 2 months ago by Anders Johnsen

Modified:
8 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Mads Ager (google), Lasse Reichstein Nielsen, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Move StringBufferImpl from coreimpl to core as _StringBufferImpl. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14005

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -90 lines)			Patch
M	lib/core/string_buffer.dart	View		2 chunks	+80 lines, -1 line	0 comments	Download
M	lib/coreimpl/coreimpl.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/string_buffer.dart	View		1 chunk	+0 lines, -86 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Anders Johnsen

This move stops 'tests/language/gc_test.dart' from failing(?). I've updated bug #1487 with information.

8 years, 2 months ago (2012-10-24 09:29:49 UTC) #1

LGTM.