Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1127393006: Install headers under client/linux/dump_writer_common (Closed)

Created:
5 years, 7 months ago by Yu Xiaolei
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai, vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/google-breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Install headers under client/linux/dump_writer_common Automake did not install headers under c/l/dwc, which caused compile errors when building against an installed breakpad, since other headers (e.g. client/linux/handler/exception_handler.h) depended on it. This commit adds these headers to the list of automake installed files. R=vapier@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/b9f9f4e84005d978b1d08e653f1571588ecaab25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -32 lines) Patch
M Makefile.am View 1 chunk +3 lines, -0 lines 0 comments Download
M Makefile.in View 9 chunks +63 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
vapier
lgtm
5 years, 1 month ago (2015-11-11 05:42:46 UTC) #3
vapier
5 years, 1 month ago (2015-11-11 06:11:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9f9f4e84005d978b1d08e653f1571588ecaab25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698