Create histograms to track time-to-error values for different errors.

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/shared_memory.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/stl_util.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
+#include "base/time/time.h"
 #include "content/browser/appcache/appcache_interceptor.h"
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/cert_store_impl.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/download/save_file_resource_handler.h"
 #include "content/browser/fileapi/chrome_blob_storage_context.h"
 #include "content/browser/frame_host/navigation_request_info.h"
 #include "content/browser/frame_host/navigator.h"
@@ skipping 818 matching lines @@
   ResourceRequestInfo* info = loader->GetRequestInfo();
 
   // Record final result of all resource loads.
   if (info->GetResourceType() == RESOURCE_TYPE_MAIN_FRAME) {
     // This enumeration has "3" appended to its name to distinguish it from
     // older versions.
     UMA_HISTOGRAM_SPARSE_SLOWLY(
         "Net.ErrorCodesForMainFrame3",
         -loader->request()->status().error());
 
+    // Record time to success and error for the most common errors, and for
+    // the aggregate remainder errors.

[mmenke, 2015/05/12 18:23:26]

High level question:

What's the motivation for adding timing hooks here instead of in
https://code.google.com/p/chromium/codesearch#chromium/src/net/url_request/ur...

Looks like there's also a cancel time there.  The times here do include
redirects, and those don't, but adding yet another incomparable set of time
histograms.

I suppose I do want to get rid of the LOAD_MAIN_FRAME flag, and we can't only
filter out the non-main frame resources there without using it.

[Randy Smith (Not in Mondays), 2015/05/12 20:51:39]

Discussed on main CL thread; IMO no code changes came from discussion.

+    base::TimeDelta request_loading_time(
+        base::Time::Now() - loader->request()->request_time());
+    switch (loader->request()->status().error()) {

[mmenke, 2015/05/12 18:23:26]

Looking at error without looking at loader->request()->status().status() makes
me nervous.

[Randy Smith (Not in Mondays), 2015/05/12 20:51:39]

Believe main thread discussion left this as ok to be consistent wiht the
ErrorCodesForMainFrame3 histogram above.

+      case net::OK:
+        UMA_HISTOGRAM_LONG_TIMES(
+            "Net.RequestTimeToSuccess", request_loading_time);

[mmenke, 2015/05/12 18:23:26]

optional:  May want to add another dot in here, to make them stand out more.

Net.RequestTime.Blah

[Randy Smith (Not in Mondays), 2015/05/12 20:51:39]

Good idea; done.

+        break;
+      case net::ERR_ABORTED:

[mmenke, 2015/05/12 18:23:26]

We should include loader->request()->status().status() == CANCELED in this
block, too.

[Randy Smith (Not in Mondays), 2015/05/12 20:51:39]

Left as is for compatibility with ErrorCodesForMainFrame3 above as per main
thread discussion.

+        UMA_HISTOGRAM_LONG_TIMES(
+            "Net.RequestTimeToErrAborted", request_loading_time);
+        break;
+      case net::ERR_TIMED_OUT:
+        UMA_HISTOGRAM_LONG_TIMES(
+            "Net.RequestTimeToErrTimedOut", request_loading_time);
+        break;
+      case net::ERR_CONNECTION_RESET:
+        UMA_HISTOGRAM_LONG_TIMES(
+            "Net.RequestTimeToErrConnectionReset", request_loading_time);
+        break;
+      case net::ERR_INTERNET_DISCONNECTED:
+        UMA_HISTOGRAM_LONG_TIMES(
+            "Net.RequestTimeToErrInternetDisconnected", request_loading_time);
+        break;

[jkarlin, 2015/05/12 18:26:06]

Perhaps ERR_CONNECTION_REFUSED, ERR_CONNECTION_TIMED_OUT, and
ERR_NAME_NOT_RESOLVED as well? Those all seem to show up a fair bit in
Net.ErrorCodesForMainFrame3 UMA. 

[Randy Smith (Not in Mondays), 2015/05/12 20:51:39]

ERR_NAME_NOT_RESOLVED was an oversight on my part; added.  CONNECTION_REFUSED
doesn't seem that high to me (close to a tenth of
INTERNET_DISCONNECTED/NAME_NOT_RESOLVED in an android only everything UMA view)
and I can't find CONNECTION_TIMED_OUT at all (as opposed to TIMED_OUT, which I'm
already including).

I've also sorted these by name, which might have been the confusion with the
timed out errors.

+      default:
+        UMA_HISTOGRAM_LONG_TIMES(
+            "Net.RequestTimeToMiscError", request_loading_time);
+        break;
+    }
+
     if (loader->request()->url().SchemeIsCryptographic()) {
       if (loader->request()->url().host() == "www.google.com") {
         UMA_HISTOGRAM_SPARSE_SLOWLY("Net.ErrorCodesForHTTPSGoogleMainFrame2",
                                     -loader->request()->status().error());
       }
 
       int num_valid_scts = std::count_if(
           loader->request()->ssl_info().signed_certificate_timestamps.begin(),
           loader->request()->ssl_info().signed_certificate_timestamps.end(),
           IsValidatedSCT);
@@ skipping 1470 matching lines @@
 
   // Add a flag to selectively bypass the data reduction proxy if the resource
   // type is not an image.
   if (request_data.resource_type != RESOURCE_TYPE_IMAGE)
     load_flags |= net::LOAD_BYPASS_DATA_REDUCTION_PROXY;
 
   return load_flags;
 }
 
 }  // namespace content