Be explicit about forcing TouchSelectionController updates

Reland "Be explicit about forcing TouchSelectionController updates"

This change landed in r329325 but was reverted due to an
uninitialized member variable. The issue has been fixed.

Original description: ----------------------------

Previously, cached values in the TouchSelectionController would be reset
to force future selection updates. However, these cached values can
actually be used outside of selection update calls, e.g., when force
showing the selection from the current cached values. Instead of
resetting the cached values, simply set a dirty bit that forces an
update, avoiding issues when dealing with the reset values.

BUG=393025
Committed: https://crrev.com/da232ee4d57ce8e6a8b3d4f9f2795c06b3720c0f
Cr-Commit-Position: refs/heads/master@{#329422}

[jdduke (slow), 2015-05-11 21:53:06]

jdduke@chromium.org changed reviewers:
+ mohsen@chromium.org

[jdduke (slow), 2015-05-11 21:53:06]

mohsen@: PTAL, thanks. donnd@ uncovered this when adding a unit test in
crrev.com/1102933003.

[mohsen, 2015-05-12 00:26:57]

LGTM, though you need to rebase because of r329191.

[jdduke (slow), 2015-05-12 00:36:43]

On 2015/05/12 00:26:57, mohsen wrote:
> LGTM, though you need to rebase because of r329191.

Yup, thanks!

[jdduke (slow), 2015-05-12 00:36:47]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2015-05-12 00:36:47]

The patchset sent to the CQ was uploaded after l-g-t-m from mohsen@chromium.org
Link to the patchset: https://codereview.chromium.org/1127383007/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-05-12 00:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1127383007/20001

[commit-bot: I haz the power, 2015-05-12 02:17:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 02:19:13]

Patchset 2 (id:??) landed as
https://crrev.com/fdcf817da49ee92fe191981f7525503444f75f83
Cr-Commit-Position: refs/heads/master@{#329325}

[benwells, 2015-05-12 04:51:17]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1139533006/ by benwells@chromium.org.

The reason for reverting is: This has caused failures on the memory bots.
e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179

Sample test output:
[ RUN      ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection
==6485== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f5bc93bb605 in
ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound
const&, ui::SelectionBound const&)
ui/touch_selection/touch_selection_controller.cc:71:27
    #1 0x7f5bc922803a in
ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool,
gfx::RectF const&, bool)
ui/touch_selection/touch_selection_controller_unittest.cc:147:5
    #2 0x7f5bc9278c8d in
ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody()
ui/touch_selection/touch_selection_controller_unittest.cc:946:3
    #3 0x7f5bc93631dc in HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
void> testing/gtest/src/gtest.cc:2420:12
    #4 0x7f5bc93631dc in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0
    #5 0x7f5bc9365a4c in testing::TestInfo::Run()
testing/gtest/src/gtest.cc:2612:5
    #6 0x7f5bc93673f6 in testing::TestCase::Run()
testing/gtest/src/gtest.cc:2730:5
    #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4602:11
    #8 0x7f5bc9383ce2 in
HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2420:12
    #9 0x7f5bc9383ce2 in testing::UnitTest::Run()
testing/gtest/src/gtest.cc:4220:0
    #10 0x7f5bc93078a3 in RUN_ALL_TESTS
testing/gtest/include/gtest/gtest.h:2326:10
    #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**)
base/test/run_all_unittests.cc:25:10
    #13 0x7f5bc92f85ee in Run base/callback.h:396:12
    #14 0x7f5bc92f85ee in base::(anonymous
namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int,
bool, base::Callback\u003Cvoid ()> const&)
base/test/launcher/unit_test_launcher.cc:184:0
    #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**,
base::Callback\u003Cint ()> const&)
base/test/launcher/unit_test_launcher.cc:423:10
    #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #17 0x7f5bc206a76c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226:0
    #18 0x7f5bc9188f38 in _start ??:0:0

  Uninitialized value was created by a heap allocation
    #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0
    #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp()
ui/touch_selection/touch_selection_controller_unittest.cc:65:23
    #2 0x7f5bc9362f57 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
void> testing/gtest/src/gtest.cc:2420:12
    #3 0x7f5bc9362f57 in testing::Test::Run() testing/gtest/src/gtest.cc:2432:0
    #4 0x7f5bc9365a4c in testing::TestInfo::Run()
testing/gtest/src/gtest.cc:2612:5
    #5 0x7f5bc93673f6 in testing::TestCase::Run()
testing/gtest/src/gtest.cc:2730:5
    #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests()
testing/gtest/src/gtest.cc:4602:11
    #7 0x7f5bc9383ce2 in
HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2420:12
    #8 0x7f5bc9383ce2 in testing::UnitTest::Run()
testing/gtest/src/gtest.cc:4220:0
    #9 0x7f5bc93078a3 in RUN_ALL_TESTS
testing/gtest/include/gtest/gtest.h:2326:10
    #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
    #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**)
base/test/run_all_unittests.cc:25:10
    #12 0x7f5bc92f85ee in Run base/callback.h:396:12
    #13 0x7f5bc92f85ee in base::(anonymous
namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int,
bool, base::Callback\u003Cvoid ()> const&)
base/test/launcher/unit_test_launcher.cc:184:0
    #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**,
base::Callback\u003Cint ()> const&)
base/test/launcher/unit_test_launcher.cc:423:10
    #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
    #16 0x7f5bc206a76c in __libc_start_main
/build/buildd/eglibc-2.15/csu/libc-start.c:226:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605)
Exiting

.

[jdduke (slow), 2015-05-12 15:03:01]

On 2015/05/12 04:51:17, benwells wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1139533006/ by mailto:benwells@chromium.org.
> 
> The reason for reverting is: This has caused failures on the memory bots.
>
e.g.:http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/6179
> 
> Sample test output:
> [ RUN      ] TouchSelectionControllerTest.AllowShowingFromCurrentSelection
> ==6485== WARNING: MemorySanitizer: use-of-uninitialized-value
>     #0 0x7f5bc93bb605 in
> ui::TouchSelectionController::OnSelectionBoundsChanged(ui::SelectionBound
> const&, ui::SelectionBound const&)
> ui/touch_selection/touch_selection_controller.cc:71:27
>     #1 0x7f5bc922803a in
> ui::TouchSelectionControllerTest::ChangeSelection(gfx::RectF const&, bool,
> gfx::RectF const&, bool)
> ui/touch_selection/touch_selection_controller_unittest.cc:147:5
>     #2 0x7f5bc9278c8d in
>
ui::TouchSelectionControllerTest_AllowShowingFromCurrentSelection_Test::TestBody()
> ui/touch_selection/touch_selection_controller_unittest.cc:946:3
>     #3 0x7f5bc93631dc in
HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
> void> testing/gtest/src/gtest.cc:2420:12
>     #4 0x7f5bc93631dc in testing::Test::Run()
testing/gtest/src/gtest.cc:2436:0
>     #5 0x7f5bc9365a4c in testing::TestInfo::Run()
> testing/gtest/src/gtest.cc:2612:5
>     #6 0x7f5bc93673f6 in testing::TestCase::Run()
> testing/gtest/src/gtest.cc:2730:5
>     #7 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests()
> testing/gtest/src/gtest.cc:4602:11
>     #8 0x7f5bc9383ce2 in
> HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,
bool>
> testing/gtest/src/gtest.cc:2420:12
>     #9 0x7f5bc9383ce2 in testing::UnitTest::Run()
> testing/gtest/src/gtest.cc:4220:0
>     #10 0x7f5bc93078a3 in RUN_ALL_TESTS
> testing/gtest/include/gtest/gtest.h:2326:10
>     #11 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
>     #12 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**)
> base/test/run_all_unittests.cc:25:10
>     #13 0x7f5bc92f85ee in Run base/callback.h:396:12
>     #14 0x7f5bc92f85ee in base::(anonymous
> namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int,
> bool, base::Callback\u003Cvoid ()> const&)
> base/test/launcher/unit_test_launcher.cc:184:0
>     #15 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**,
> base::Callback\u003Cint ()> const&)
> base/test/launcher/unit_test_launcher.cc:423:10
>     #16 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
>     #17 0x7f5bc206a76c in __libc_start_main
> /build/buildd/eglibc-2.15/csu/libc-start.c:226:0
>     #18 0x7f5bc9188f38 in _start ??:0:0
> 
>   Uninitialized value was created by a heap allocation
>     #0 0x7f5bc91da0e2 in operator new(unsigned long) ??:0:0
>     #1 0x7f5bc927c95c in ui::TouchSelectionControllerTest::SetUp()
> ui/touch_selection/touch_selection_controller_unittest.cc:65:23
>     #2 0x7f5bc9362f57 in
HandleExceptionsInMethodIfSupported\u003Ctesting::Test,
> void> testing/gtest/src/gtest.cc:2420:12
>     #3 0x7f5bc9362f57 in testing::Test::Run()
testing/gtest/src/gtest.cc:2432:0
>     #4 0x7f5bc9365a4c in testing::TestInfo::Run()
> testing/gtest/src/gtest.cc:2612:5
>     #5 0x7f5bc93673f6 in testing::TestCase::Run()
> testing/gtest/src/gtest.cc:2730:5
>     #6 0x7f5bc9384d03 in testing::internal::UnitTestImpl::RunAllTests()
> testing/gtest/src/gtest.cc:4602:11
>     #7 0x7f5bc9383ce2 in
> HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,
bool>
> testing/gtest/src/gtest.cc:2420:12
>     #8 0x7f5bc9383ce2 in testing::UnitTest::Run()
> testing/gtest/src/gtest.cc:4220:0
>     #9 0x7f5bc93078a3 in RUN_ALL_TESTS
> testing/gtest/include/gtest/gtest.h:2326:10
>     #10 0x7f5bc93078a3 in base::TestSuite::Run() base/test/test_suite.cc:228:0
>     #11 0x7f5bc92f7b2d in (anonymous namespace)::RunTestSuite(int, char**)
> base/test/run_all_unittests.cc:25:10
>     #12 0x7f5bc92f85ee in Run base/callback.h:396:12
>     #13 0x7f5bc92f85ee in base::(anonymous
> namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int,
> bool, base::Callback\u003Cvoid ()> const&)
> base/test/launcher/unit_test_launcher.cc:184:0
>     #14 0x7f5bc92f7f5b in base::LaunchUnitTests(int, char**,
> base::Callback\u003Cint ()> const&)
> base/test/launcher/unit_test_launcher.cc:423:10
>     #15 0x7f5bc92f792d in main base/test/run_all_unittests.cc:37:10
>     #16 0x7f5bc206a76c in __libc_start_main
> /build/buildd/eglibc-2.15/csu/libc-start.c:226:0
> 
> SUMMARY: MemorySanitizer: use-of-uninitialized-value
>
(/mnt/data/b/build/slave/Linux_MSan_Tests/build/src/out/Release/ui_touch_selection_unittests+0x285605)
> Exiting
> 
> .

Thanks, sigh, missed the member initialization.

[jdduke (slow), 2015-05-12 15:05:17]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2015-05-12 15:05:18]

The patchset sent to the CQ was uploaded after l-g-t-m from mohsen@chromium.org
Link to the patchset: https://codereview.chromium.org/1127383007/#ps40001
(title: "Initialize force_next_update_")

[commit-bot: I haz the power, 2015-05-12 15:05:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1127383007/40001

[commit-bot: I haz the power, 2015-05-12 16:51:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-12 16:52:28]

Patchset 3 (id:??) landed as
https://crrev.com/da232ee4d57ce8e6a8b3d4f9f2795c06b3720c0f
Cr-Commit-Position: refs/heads/master@{#329422}