Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 1127373006: Fix DCHECK() firing on GPU bots. (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, zmo1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK() firing on GPU bots. Looks like the extra frame duration is enough extra leeway to match a 1-frame cadence if it was previously on the edge. BUG=439548 TEST=new unittest Committed: https://crrev.com/326d757e1864bedb122f811e70add8d507d1952c Cr-Commit-Position: refs/heads/master@{#329914}

Patch Set 1 #

Patch Set 2 : Add test! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M media/filters/video_cadence_estimator.cc View 1 chunk +12 lines, -5 lines 0 comments Download
M media/filters/video_cadence_estimator_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
DaleCurtis
xhwang: I believe this is due to floating point precision errors as both my math ...
5 years, 7 months ago (2015-05-14 18:19:58 UTC) #2
DaleCurtis
Eh, who cares about math, brute force run over expected intervals and durations yielded the ...
5 years, 7 months ago (2015-05-14 18:40:20 UTC) #3
DaleCurtis
cc:zmo as an FYI since he's gpu sheriff.
5 years, 7 months ago (2015-05-14 18:56:20 UTC) #4
sandersd (OOO until July 31)
lgtm
5 years, 7 months ago (2015-05-14 18:58:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127373006/20001
5 years, 7 months ago (2015-05-14 19:00:26 UTC) #8
xhwang
lgtm
5 years, 7 months ago (2015-05-14 19:29:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 20:02:47 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 20:03:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/326d757e1864bedb122f811e70add8d507d1952c
Cr-Commit-Position: refs/heads/master@{#329914}

Powered by Google App Engine
This is Rietveld 408576698