Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1127363003: Insert the right checks for redirecting factories to deferred constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: update to status-file rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 7d96a64f2d686a5c2f4375fe224b8cbb3702ae9a..06368b571de57317179c1e413480a4ff2dd3a19f 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -1960,9 +1960,14 @@ abstract class ConstructorElementX extends FunctionElementX
: super(name, kind, modifiers, enclosing, false);
FunctionElement immediateRedirectionTarget;
+ PrefixElement redirectionDeferredPrefix;
bool get isRedirectingFactory => immediateRedirectionTarget != null;
+ // TODO(johnniwinther): This should also return true for cyclic redirecting
+ // generative constructors.
+ bool get isCyclicRedirection => effectiveTarget.isRedirectingFactory;
+
/// This field is set by the post process queue when checking for cycles.
ConstructorElement internalEffectiveTarget;
DartType effectiveTargetType;
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698