Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 1127363002: [V8] Reland https://codereview.chromium.org/1121833003/ (Closed)

Created:
5 years, 7 months ago by kozy
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/scanner.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kozy
Yang, ptal. I've added missed Test Expectation in https://codereview.chromium.org/1135493002/ I'll wait for successful runs of ...
5 years, 7 months ago (2015-05-07 09:59:57 UTC) #1
Yang
On 2015/05/07 09:59:57, kozyatinskiy wrote: > Yang, ptal. > > I've added missed Test Expectation ...
5 years, 7 months ago (2015-05-07 10:05:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127363002/1
5 years, 7 months ago (2015-05-07 11:47:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 11:49:13 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 11:49:26 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/112f8dc97a34cd6b8a7febf191a09a513c4a3e3f
Cr-Commit-Position: refs/heads/master@{#28295}

Powered by Google App Engine
This is Rietveld 408576698